* perf build failed on linux -next on i386 build @ 2019-09-26 17:29 Naresh Kamboju 2019-09-26 17:36 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 4+ messages in thread From: Naresh Kamboju @ 2019-09-26 17:29 UTC (permalink / raw) To: Peter Zijlstra, mingo, acme, alexander.shishkin, jolsa, namhyung Cc: open list, lkft-triage, Linux-Next Mailing List perf build failed on linux -next on i386 build build error: perf-in.o: In function `libunwind__x86_reg_id': tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: undefined reference to `pr_err' tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: undefined reference to `pr_err' - Naresh ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: perf build failed on linux -next on i386 build 2019-09-26 17:29 perf build failed on linux -next on i386 build Naresh Kamboju @ 2019-09-26 17:36 ` Arnaldo Carvalho de Melo 2019-09-26 20:35 ` Naresh Kamboju 0 siblings, 1 reply; 4+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-09-26 17:36 UTC (permalink / raw) To: Naresh Kamboju Cc: Peter Zijlstra, mingo, alexander.shishkin, jolsa, namhyung, open list, lkft-triage, Linux-Next Mailing List Em Thu, Sep 26, 2019 at 10:59:41PM +0530, Naresh Kamboju escreveu: > perf build failed on linux -next on i386 build > > build error: > perf-in.o: In function `libunwind__x86_reg_id': > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > undefined reference to `pr_err' > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > undefined reference to `pr_err' Can you try with the following patch? diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c index 05920e3edf7a..47357973b55b 100644 --- a/tools/perf/arch/x86/util/unwind-libunwind.c +++ b/tools/perf/arch/x86/util/unwind-libunwind.c @@ -1,11 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 #include <errno.h> +#include "../../util/debug.h" #ifndef REMOTE_UNWIND_LIBUNWIND #include <libunwind.h> #include "perf_regs.h" #include "../../util/unwind.h" -#include "../../util/debug.h" #endif #ifdef HAVE_ARCH_X86_64_SUPPORT ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: perf build failed on linux -next on i386 build 2019-09-26 17:36 ` Arnaldo Carvalho de Melo @ 2019-09-26 20:35 ` Naresh Kamboju 2019-09-27 15:42 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 4+ messages in thread From: Naresh Kamboju @ 2019-09-26 20:35 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra, mingo, alexander.shishkin, jolsa, namhyung, open list, lkft-triage, Linux-Next Mailing List On Thu, 26 Sep 2019 at 23:06, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > > Em Thu, Sep 26, 2019 at 10:59:41PM +0530, Naresh Kamboju escreveu: > > perf build failed on linux -next on i386 build > > > > build error: > > perf-in.o: In function `libunwind__x86_reg_id': > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > > undefined reference to `pr_err' > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > > undefined reference to `pr_err' > > Can you try with the following patch? Thanks for the patch. After applying this below patch build completes. > > > diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c > index 05920e3edf7a..47357973b55b 100644 > --- a/tools/perf/arch/x86/util/unwind-libunwind.c > +++ b/tools/perf/arch/x86/util/unwind-libunwind.c > @@ -1,11 +1,11 @@ > // SPDX-License-Identifier: GPL-2.0 > > #include <errno.h> > +#include "../../util/debug.h" > #ifndef REMOTE_UNWIND_LIBUNWIND > #include <libunwind.h> > #include "perf_regs.h" > #include "../../util/unwind.h" > -#include "../../util/debug.h" > #endif > > #ifdef HAVE_ARCH_X86_64_SUPPORT - Naresh ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: perf build failed on linux -next on i386 build 2019-09-26 20:35 ` Naresh Kamboju @ 2019-09-27 15:42 ` Arnaldo Carvalho de Melo 0 siblings, 0 replies; 4+ messages in thread From: Arnaldo Carvalho de Melo @ 2019-09-27 15:42 UTC (permalink / raw) To: Naresh Kamboju Cc: Arnaldo Carvalho de Melo, Peter Zijlstra, mingo, alexander.shishkin, jolsa, namhyung, open list, lkft-triage, Linux-Next Mailing List Em Fri, Sep 27, 2019 at 02:05:32AM +0530, Naresh Kamboju escreveu: > On Thu, 26 Sep 2019 at 23:06, Arnaldo Carvalho de Melo > <arnaldo.melo@gmail.com> wrote: > > > > Em Thu, Sep 26, 2019 at 10:59:41PM +0530, Naresh Kamboju escreveu: > > > perf build failed on linux -next on i386 build > > > > > > build error: > > > perf-in.o: In function `libunwind__x86_reg_id': > > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > > > undefined reference to `pr_err' > > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109: > > > undefined reference to `pr_err' > > > > Can you try with the following patch? > > Thanks for the patch. > After applying this below patch build completes. Thanks for the report and for testing it, appreciated, - Arnaldo > > > > > > > diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c > > index 05920e3edf7a..47357973b55b 100644 > > --- a/tools/perf/arch/x86/util/unwind-libunwind.c > > +++ b/tools/perf/arch/x86/util/unwind-libunwind.c > > @@ -1,11 +1,11 @@ > > // SPDX-License-Identifier: GPL-2.0 > > > > #include <errno.h> > > +#include "../../util/debug.h" > > #ifndef REMOTE_UNWIND_LIBUNWIND > > #include <libunwind.h> > > #include "perf_regs.h" > > #include "../../util/unwind.h" > > -#include "../../util/debug.h" > > #endif > > > > #ifdef HAVE_ARCH_X86_64_SUPPORT > > - Naresh -- - Arnaldo ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-27 15:43 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-26 17:29 perf build failed on linux -next on i386 build Naresh Kamboju 2019-09-26 17:36 ` Arnaldo Carvalho de Melo 2019-09-26 20:35 ` Naresh Kamboju 2019-09-27 15:42 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox