From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Naveen Rao <naveen.n.rao@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH] tracing/probe: Test nr_args match in looking for same probe events
Date: Sat, 28 Sep 2019 02:56:51 -0700 [thread overview]
Message-ID: <20190928025651.2735f7a306bfda881a318b12@kernel.org> (raw)
In-Reply-To: <20190928011748.599255f6ffc9a4831e1efd2c@kernel.org>
On Sat, 28 Sep 2019 01:17:48 -0700
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> If we found that 2 probes have different number of argument should not be
> folded at all.
> Also, we have to adjust error log position. Attached patch will fix those
> errors correctly as bellow.
Oops, missed the fixed tag. Anyway I'll send it as a patch mail.
Thank you,
>
> /sys/kernel/debug/tracing # echo p:myevent kernel_read %ax %bx >> kprobe_events
> /sys/kernel/debug/tracing # echo p:myevent kernel_read %ax %bx >> kprobe_events
> sh: write error: File exists
> /sys/kernel/debug/tracing # echo p:myevent kernel_read %ax >> kprobe_events
> sh: write error: File exists
> /sys/kernel/debug/tracing # echo p:myevent kernel_read %ax %bx %cx >> kprobe_eve
> nts
> sh: write error: File exists
> /sys/kernel/debug/tracing # cat error_log
> [ 15.917727] trace_kprobe: error: There is already the exact same probe event
> Command: p:myevent kernel_read %ax %bx
> ^
> [ 24.890638] trace_kprobe: error: Argument type or name is different from existing probe
> Command: p:myevent kernel_read %ax
> ^
> [ 31.480521] trace_kprobe: error: Argument type or name is different from existing probe
> Command: p:myevent kernel_read %ax %bx %cx
> ^
>
> Thank you,
>
> --
> Masami Hiramatsu
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-09-28 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 9:50 [PATCH] tracing/probe: Test nr_args match in looking for same probe events Steven Rostedt
2019-09-27 13:38 ` Srikar Dronamraju
2019-09-27 15:06 ` Steven Rostedt
2019-09-27 17:54 ` Srikar Dronamraju
2019-09-28 8:17 ` Masami Hiramatsu
2019-09-28 9:56 ` Masami Hiramatsu [this message]
2019-09-28 9:59 ` [PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe Masami Hiramatsu
2019-09-28 21:11 ` Steven Rostedt
2019-09-29 8:14 ` Masami Hiramatsu
2019-09-30 10:28 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190928025651.2735f7a306bfda881a318b12@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox