Re: [PATCH] Make is_signed_type() simpler

Rasmus Villemoes
2019-09-29T20:21:53Z

On 29/09/2019 22.06, Alexey Dobriyan wrote:
> * Simply compare -1 with 0,
> * Drop unnecessary parenthesis sets
>
> -#define is_signed_type(type) (((type)(-1)) < (type)1)
> +#define is_signed_type(type) ((type)-1 < 0)

NAK. I wrote it that way to avoid -Wtautological-compare when type is
unsigned.

Rasmus