From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CB7C388F3 for ; Mon, 30 Sep 2019 16:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E42F21855 for ; Mon, 30 Sep 2019 16:53:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="u24PiQrB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732408AbfI3QxH (ORCPT ); Mon, 30 Sep 2019 12:53:07 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:40403 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727884AbfI3QxH (ORCPT ); Mon, 30 Sep 2019 12:53:07 -0400 Received: by mail-pl1-f194.google.com with SMTP id d22so4132189pll.7 for ; Mon, 30 Sep 2019 09:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f+nerH7/3f5jVInNGQWz0pf5Q2oTiewZHT4IGh7OAlM=; b=u24PiQrBZ9wkrsV1JyAofa5Q/EtOFdvZVmwLAYLNZ041sgLRL+F7Ex2m9gS9K3t9Vo fqjokZE6O8IHOJteak/MSW7MxymZLGwq29nwKsot1G/AZpYLR+UlA5DaP8lsBirxjyDE HqvE4I9kK/ZE/0Da9LZeSHurwnqwLVJrfttCQnuVLoUG26SlonXpq1fPk3PMQ4OpClMZ 3rHwZCRrpKOGjaAffxwDtfC1ZiM++dBtdlA5htmxlIfgZ5qg3IkNK0oGAcNrhoGuX7er XaFaGMlGqRQlYK17Aew5KelSOZ8qHErlYDRp+6FIr2F1VPdZIvgyvtpMq5oc5JNEuVYu nsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f+nerH7/3f5jVInNGQWz0pf5Q2oTiewZHT4IGh7OAlM=; b=GVjy2w7IPsJ3vT40jJg27Nos+pYAhTB/eDNMWTl3w90c7bPuht6Psrdy5RINM+Qzp1 XoJHyiQ+5V+OlqkuwjH2S0EVyUfm+0dR9KCPT5/vJKJUEaCzXldip5bChJDKIuGiTrQT BEUH++Y/DGPXv3HBuTZCj/TlkuFzZ1N/Wlw3cr0ORrGiyqaR51WDOKFmzg3bo80Aw4PP strmDB7y+T2iCZnC4MRejUoO67hVqLoZbTI92wxVO1+w2Bxb8pdKgJmpPYb21Cq1F/ss ysgzcWq3Prq7FV4DQV4IV8qTPJqEvW80gPPQUtnv4vBcq1+16+/q/TIoUNdHh4F/zhX4 lFKQ== X-Gm-Message-State: APjAAAUR+P6LiU0O6MJCWGXS8lQhdfj4SaDEErwkDmukjbwaTu1A7gw2 Q/NGJpz+lbRao+6exS763dTBwQ== X-Google-Smtp-Source: APXvYqzS2SQCyITvMRpLg6lGb2f95ywFpL74G4S5Pm3QeC98Yx2Q4IidhLo77R+Fa5fDC2DN0+eJ+A== X-Received: by 2002:a17:902:7003:: with SMTP id y3mr21428242plk.239.1569862386118; Mon, 30 Sep 2019 09:53:06 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h8sm12990265pfo.64.2019.09.30.09.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 09:53:06 -0700 (PDT) Date: Mon, 30 Sep 2019 09:52:58 -0700 From: Stephen Hemminger To: Borislav Petkov Cc: Michal Kubecek , linux-rdma@vger.kernel.org, Saeed Mahameed , Leon Romanovsky , netdev@vger.kernel.org, lkml Subject: Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! Message-ID: <20190930095258.1db16eb2@hermes.lan> In-Reply-To: <20190930162910.GI29694@zn.tnic> References: <20190930141316.GG29694@zn.tnic> <20190930154535.GC22120@unicorn.suse.cz> <20190930162910.GI29694@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Sep 2019 18:29:10 +0200 Borislav Petkov wrote: > On Mon, Sep 30, 2019 at 05:45:35PM +0200, Michal Kubecek wrote: > > On Mon, Sep 30, 2019 at 04:13:17PM +0200, Borislav Petkov wrote: > > > I'm seeing this on i386 allyesconfig builds of current Linus master: > > > > > > ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! > > > make[1]: *** [__modpost] Error 1 > > > make: *** [modules] Error 2 > > > > This is usually result of dividing (or modulo) by a 64-bit integer. Can > > you identify where (file and line number) is the __umoddi3() call > > generated? > > Did another 32-bit allyesconfig build. It said: > > ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.o: in function `mlx5dr_icm_alloc_chunk': > dr_icm_pool.c:(.text+0x733): undefined reference to `__umoddi3' > make: *** [vmlinux] Error 1 > > The .s file then points to the exact location: > > # drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.c:140: align_diff = icm_mr->icm_start_addr % align_base; > pushl %ebx # align_base > pushl %ecx # align_base > call __umoddi3 # > popl %edx # > popl %ecx # Since align_base is a power of 2 masking should work as well.