Re: [PATCH v1 3/5] staging: fieldbus core: add support for device configuration

Greg KH
2019-10-02T15:24:03Z

On Wed, Oct 02, 2019 at 11:07:47AM -0400, Sven Van Asbroeck wrote:
> On Mon, Sep 30, 2019 at 10:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Why is a new way of doing configuration needed here? What does this
> > provide that the current code doesn't already do?
>
> The fieldbus core doesn't have a configuration mechanism yet. This
> patch adds one.
> I deliberately omitted configuration when the core was added - I wanted to keep
> complexity to a minimum. I'm sorry I didn't make this clearer.
>
> As a result, the current core can only work with cards that either don't require
> any config, or get it straight from the network/PLC. Profinet is a good example
> of this. Most cards do require config however. So does the hms flnet card, which
> I tried to add in the patchset.

If the code works with some subset now, then why not work to get this
cleaned up properly and out of staging and then add new features like
this type of configuration system afterward?

Why is this a requirement to add while the code is in staging?

thanks,

greg k-h