From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481D9C388F3 for ; Mon, 30 Sep 2019 16:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 285F72168B for ; Mon, 30 Sep 2019 16:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732352AbfI3QhV (ORCPT ); Mon, 30 Sep 2019 12:37:21 -0400 Received: from fieldses.org ([173.255.197.46]:38388 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731459AbfI3QhV (ORCPT ); Mon, 30 Sep 2019 12:37:21 -0400 Received: by fieldses.org (Postfix, from userid 2815) id EECE063E; Mon, 30 Sep 2019 12:37:20 -0400 (EDT) Date: Mon, 30 Sep 2019 12:37:20 -0400 From: "J. Bruce Fields" To: YueHaibing Cc: chuck.lever@oracle.com, trondmy@gmail.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] nfsd: remove set but not used variable 'len' Message-ID: <20190930163720.GD10012@fieldses.org> References: <20190928042156.43228-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190928042156.43228-1-yuehaibing@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, applying for 5.5.--b. On Sat, Sep 28, 2019 at 12:21:56PM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/nfsd/nfs4xdr.c: In function nfsd4_encode_splice_read: > fs/nfsd/nfs4xdr.c:3464:7: warning: variable len set but not used [-Wunused-but-set-variable] > > It is not used since commit 83a63072c815 ("nfsd: fix nfs read eof detection") > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > fs/nfsd/nfs4xdr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index 533d0fc..1883370 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -3461,7 +3461,6 @@ static __be32 nfsd4_encode_splice_read( > struct xdr_stream *xdr = &resp->xdr; > struct xdr_buf *buf = xdr->buf; > u32 eof; > - long len; > int space_left; > __be32 nfserr; > __be32 *p = xdr->p - 2; > @@ -3470,7 +3469,6 @@ static __be32 nfsd4_encode_splice_read( > if (xdr->end - xdr->p < 1) > return nfserr_resource; > > - len = maxcount; > nfserr = nfsd_splice_read(read->rd_rqstp, read->rd_fhp, > file, read->rd_offset, &maxcount, &eof); > read->rd_length = maxcount; > -- > 2.7.4 >