* [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler
@ 2019-09-20 15:13 Mihail Atanassov
2019-09-23 2:41 ` james qian wang (Arm Technology China)
0 siblings, 1 reply; 3+ messages in thread
From: Mihail Atanassov @ 2019-09-20 15:13 UTC (permalink / raw)
To: dri-devel@lists.freedesktop.org
Cc: Mihail Atanassov, nd, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
Lowry Li (Arm Technology China), linux-kernel@vger.kernel.org
No change in behaviour; IRQ_RETVAL is about twice as popular as
manually writing out the ternary.
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
index d567ab7ed314..1b42095969e7 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
@@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts)
if (gcu_status & GLB_IRQ_STATUS_PIPE1)
evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status);
- return gcu_status ? IRQ_HANDLED : IRQ_NONE;
+ return IRQ_RETVAL(gcu_status);
}
#define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler
2019-09-20 15:13 [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler Mihail Atanassov
@ 2019-09-23 2:41 ` james qian wang (Arm Technology China)
2019-10-01 11:06 ` Ayan Halder
0 siblings, 1 reply; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-09-23 2:41 UTC (permalink / raw)
To: Mihail Atanassov
Cc: dri-devel@lists.freedesktop.org, nd, Liviu Dudau, Brian Starkey,
David Airlie, Daniel Vetter, Lowry Li (Arm Technology China),
linux-kernel@vger.kernel.org
On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote:
> No change in behaviour; IRQ_RETVAL is about twice as popular as
> manually writing out the ternary.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> index d567ab7ed314..1b42095969e7 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts)
> if (gcu_status & GLB_IRQ_STATUS_PIPE1)
> evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status);
>
> - return gcu_status ? IRQ_HANDLED : IRQ_NONE;
> + return IRQ_RETVAL(gcu_status);
Hi Mihail:
Thank you for the patch.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> }
>
> #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
> --
> 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler
2019-09-23 2:41 ` james qian wang (Arm Technology China)
@ 2019-10-01 11:06 ` Ayan Halder
0 siblings, 0 replies; 3+ messages in thread
From: Ayan Halder @ 2019-10-01 11:06 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Mihail Atanassov, Lowry Li (Arm Technology China), David Airlie,
Liviu Dudau, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, nd
On Mon, Sep 23, 2019 at 02:41:44AM +0000, james qian wang (Arm Technology China) wrote:
> On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote:
> > No change in behaviour; IRQ_RETVAL is about twice as popular as
> > manually writing out the ternary.
> >
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > index d567ab7ed314..1b42095969e7 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts)
> > if (gcu_status & GLB_IRQ_STATUS_PIPE1)
> > evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status);
> >
> > - return gcu_status ? IRQ_HANDLED : IRQ_NONE;
> > + return IRQ_RETVAL(gcu_status);
>
> Hi Mihail:
>
> Thank you for the patch.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Pushed to drm-misc-next - 4b39582a8fb3c749f0fa96ec920d138f61bf00d6
>
> > }
> >
> > #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
> > --
> > 2.23.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-01 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-20 15:13 [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler Mihail Atanassov
2019-09-23 2:41 ` james qian wang (Arm Technology China)
2019-10-01 11:06 ` Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox