From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B148C352AA for ; Tue, 1 Oct 2019 11:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E16A22133F for ; Tue, 1 Oct 2019 11:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732037AbfJALh7 (ORCPT ); Tue, 1 Oct 2019 07:37:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45118 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725947AbfJALh7 (ORCPT ); Tue, 1 Oct 2019 07:37:59 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x91BWbQ3141148 for ; Tue, 1 Oct 2019 07:37:57 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vc2tyxknm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 01 Oct 2019 07:37:45 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Oct 2019 12:36:54 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 1 Oct 2019 12:36:50 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x91BanHT59834586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Oct 2019 11:36:50 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF909AE04D; Tue, 1 Oct 2019 11:36:49 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7519AAE053; Tue, 1 Oct 2019 11:36:48 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.122.211.122]) by d06av26.portsmouth.uk.ibm.com (Postfix) with SMTP; Tue, 1 Oct 2019 11:36:48 +0000 (GMT) Date: Tue, 1 Oct 2019 17:06:47 +0530 From: Srikar Dronamraju To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, tglx@linutronix.de, qais.yousef@arm.com Subject: Re: [PATCH v2 2/4] sched/fair: Move active balance logic to its own function Reply-To: Srikar Dronamraju References: <20190815145107.5318-1-valentin.schneider@arm.com> <20190815145107.5318-3-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190815145107.5318-3-valentin.schneider@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-TM-AS-GCONF: 00 x-cbid: 19100111-4275-0000-0000-0000036CDBA9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19100111-4276-0000-0000-0000387F65BF Message-Id: <20191001111601.GA32306@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-01_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010106 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +unlock: > + raw_spin_unlock_irqrestore(&busiest->lock, flags); > + > + if (status == started) > + stop_one_cpu_nowait(cpu_of(busiest), > + active_load_balance_cpu_stop, busiest, > + &busiest->active_balance_work); > + > + /* We've kicked active balancing, force task migration. */ > + if (status != cancelled_affinity) > + sd->nr_balance_failed = sd->cache_nice_tries + 1; Should we really update nr_balance_failed if status is cancelled? I do understand this behaviour was present even before this change. But still dont understand why we need to update if the current operation didn't kick active_load_balance. -- Thanks and Regards Srikar Dronamraju