From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDA6ECE587 for ; Wed, 2 Oct 2019 00:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3480920842 for ; Wed, 2 Oct 2019 00:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FUF/hhM/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728168AbfJBAhi (ORCPT ); Tue, 1 Oct 2019 20:37:38 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:38196 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfJBAhh (ORCPT ); Tue, 1 Oct 2019 20:37:37 -0400 Received: by mail-io1-f66.google.com with SMTP id u8so52867639iom.5; Tue, 01 Oct 2019 17:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jcliF93zjSpaTafpPEiTUMAs8EwGUjS9FawXIfHTmOk=; b=FUF/hhM/vBnKabjpTYNNJuImvyEzWBVpTfaLzBpXWRSHTbAb5wZkSeRPMfK6OpEVmx IOIRahBGB50RIUu6TBi49FNNwcHRR/Ve53r5c/4LZnBqcpYqqkflyECXpVX+H//XOzzM YFUwYGvWvl5hUlb3gveV9qW2kBzhz2XE69E60fYsgGBEufYPRC0cO6XiUEfm6FVLQvIe nqPfP0eWYF+d9lSu3eXkO3ZGz+SSrn96ZYoU6ymh/RnKOVQhsbC5vZHnv1QtDgDHvymb 3w6+ht2tVd5Z+oD+vavuAyoOKkhY8U9cFMkFdCruDN1VfRJH3HLJ7JLhrRFWjtwjrpnO m7fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jcliF93zjSpaTafpPEiTUMAs8EwGUjS9FawXIfHTmOk=; b=YN7yb65HA+RiPtO+yuBzZKFUJru8XnaTtqer1wXS2mBL2UwNvLYFz8//3B7rPcBAoQ Br/9EpCbu1DYXOUiciQMopIRTOEWYN7qZs+lfnHO0GhE65LYqX0tlUkzbrGXfJT3cyNp LgzMGMo8F8i82iBNejIOwtSzHh/qKaMUgwTfPq3ElnYurodN2j+6wpMHNAEQGwdRRf4e kniiTHoxCKuNyxu6OtLyHx3NEA1FD0DFUeqlQXjciok34LTx7lvZCJk1dTzdzDE0PQjn mdjT/PvmOsViRZP2T3FiD1Xx+4i93vTViJ1nOBld3hXXxcjWCO6gWZvH4wk77QLBYfH1 4S+A== X-Gm-Message-State: APjAAAUokgUD5XXtMYqRy7wnGFxBi/efRx0GRiUHCSVaE6O+bjZAIFSr DC3YH363W2rRGSziPp7XnPY= X-Google-Smtp-Source: APXvYqy+o3Crh5rKBMJbTtqAeWBE/QuO5VO0Lz6XDvh5VdH4ptgIDSyIgrcPEVz5wsdhEWSpK95zjQ== X-Received: by 2002:a92:b09:: with SMTP id b9mr997054ilf.122.1569976655713; Tue, 01 Oct 2019 17:37:35 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id v69sm8149604ila.6.2019.10.01.17.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 17:37:34 -0700 (PDT) From: Adam Ford To: linux-arm-kernel@lists.infradead.org Cc: adam.ford@logicpd.com, shawnguo@kernel.org, Adam Ford , Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: imx6q-logicpd: Fix 3.3V regulator on SDHC1 Date: Tue, 1 Oct 2019 19:37:13 -0500 Message-Id: <20191002003713.21332-2-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191002003713.21332-1-aford173@gmail.com> References: <20191002003713.21332-1-aford173@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NVCC_SD1 is driven by a selector which chooses between 3.3V and 1.8. Currently, this is pulled down by a 10k resistor, but occasionally, voltage spikes on this rail cause the regulator to jump between 1.8 and 3.3V. This patch explicitly sets GPIO_19 to choose the 3.3V rail by forcing this IO pin low to stabilize NVCC_SD1. Signed-off-by: Adam Ford diff --git a/arch/arm/boot/dts/imx6-logicpd-som.dtsi b/arch/arm/boot/dts/imx6-logicpd-som.dtsi index 547fb141ec0c..233762acbaaf 100644 --- a/arch/arm/boot/dts/imx6-logicpd-som.dtsi +++ b/arch/arm/boot/dts/imx6-logicpd-som.dtsi @@ -15,6 +15,18 @@ reg = <0x10000000 0x80000000>; }; + reg_sdhc1: regulator-sdhc1 { + compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_reg_sdhc1>; + regulator-name = "reg_sdhc1"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio4 5 GPIO_ACTIVE_LOW>; + startup-delay-us = <70000>; + enable-active-high; + }; + reg_wl18xx_vmmc: regulator-wl18xx { compatible = "regulator-fixed"; regulator-name = "vwl1837"; @@ -267,6 +279,12 @@ >; }; + pinctrl_reg_sdhc1: regsdhc1grp { + fsl,pins = < + MX6QDL_PAD_GPIO_19__GPIO4_IO05 0x1b0b0 + >; + }; + pinctrl_tempsense: tempsensegrp { fsl,pins = < MX6QDL_PAD_NANDF_CS2__GPIO6_IO15 0x1b0b0 @@ -343,7 +361,9 @@ non-removable; keep-power-in-suspend; wakeup-source; + no-1-8-v; vmmc-supply = <&sw2_reg>; + vqmmc-supply = <®_sdhc1>; status = "okay"; }; -- 2.17.1