From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v2 3/3] media: ov5640: Make 2592x1944 mode only available at 15 fps
Date: Wed, 2 Oct 2019 08:51:34 -0500 [thread overview]
Message-ID: <20191002135134.12273-4-bparrot@ti.com> (raw)
In-Reply-To: <20191002135134.12273-1-bparrot@ti.com>
The sensor data sheet clearly state that 2592x1944 only works at 15 fps
make sure we don't try to miss configure the pll out of acceptable
range.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
drivers/media/i2c/ov5640.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 103a4e8f88e1..d5b0be2c7a0a 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -1613,6 +1613,11 @@ ov5640_find_mode(struct ov5640_dev *sensor, enum ov5640_frame_rate fr,
!(mode->hact == 640 && mode->vact == 480))
return NULL;
+ /* 2592x1944 only works at 15fps */
+ if (fr != OV5640_15_FPS &&
+ (mode->hact == 2592 && mode->vact == 1944))
+ return NULL;
+
return mode;
}
--
2.17.1
next prev parent reply other threads:[~2019-10-02 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 13:51 [Patch v2 0/3] media: ov5640: updates Benoit Parrot
2019-10-02 13:51 ` [Patch v2 1/3] media: ov5640: add PIXEL_RATE control Benoit Parrot
2019-10-03 7:17 ` Jacopo Mondi
2019-10-03 7:22 ` Sakari Ailus
2019-10-03 12:07 ` Benoit Parrot
2019-10-03 14:32 ` Sakari Ailus
2019-10-03 11:59 ` Benoit Parrot
2019-10-02 13:51 ` [Patch v2 2/3] media: ov5640: Fix 1920x1080 mode to remove extra enable/disable Benoit Parrot
2019-10-03 7:26 ` Jacopo Mondi
2019-10-02 13:51 ` Benoit Parrot [this message]
2019-10-03 7:31 ` [Patch v2 3/3] media: ov5640: Make 2592x1944 mode only available at 15 fps Jacopo Mondi
2019-10-03 12:09 ` Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002135134.12273-4-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox