From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DC8C35280 for ; Wed, 2 Oct 2019 15:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9036521783 for ; Wed, 2 Oct 2019 15:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728882AbfJBPeN (ORCPT ); Wed, 2 Oct 2019 11:34:13 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:40423 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728793AbfJBPeN (ORCPT ); Wed, 2 Oct 2019 11:34:13 -0400 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1635E20006; Wed, 2 Oct 2019 15:34:10 +0000 (UTC) Date: Wed, 2 Oct 2019 17:34:10 +0200 From: Alexandre Belloni To: Dmitry Torokhov Cc: Nick Crews , Alessandro Zummo , linux-rtc@vger.kernel.org, lkml , Pavel Machek , enric.balletbo@collabora.com, Benson Leung , dlaurie@chromium.org, Daniel Kurtz Subject: Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times Message-ID: <20191002153410.GO4106@piout.net> References: <20190925203209.79941-1-ncrews@chromium.org> <20191001195342.GH4106@piout.net> <20191002103236.GM4106@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2019 08:20:34-0700, Dmitry Torokhov wrote: > > I'm still not convinced it is useful to have an error in dmesg when the > > time is invalid, as long as userspace knows it is invalid. What is the > > course of action for the end user when that happens? > > Report it, or, in our case, we will see it in the feedback logs. > However I do agree that it is not the best option, even if we report > error to userspace I am not sure if it will handle it properly. What > userspace is supposed to do when presented with -EIO or similar? > I would say probably retry a few times if it gets -EIO and simply abort in case of -EINVAL. I'm not aware of any userspace tool behaving that way though. They all simply abort. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com