Re: [PATCH] sh: kgdb: fix an implicit fallthrough warning

Daniel Thompson
2019-10-03T10:28:15Z

On Wed, Oct 02, 2019 at 05:47:56PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The switch case in arch/sh/kernel/kgdb.c can fallthrough. Add an
> appropriate comment.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

> ---
> arch/sh/kernel/kgdb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
> index 6d61f8cf4c13..0d5f3c9d52f3 100644
> --- a/arch/sh/kernel/kgdb.c
> +++ b/arch/sh/kernel/kgdb.c
> @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
> ptr = &remcomInBuffer[1];
> if (kgdb_hex2long(&ptr, &addr))
> linux_regs->pc = addr;
> + /* fallthrough */
> case 'D':
> case 'k':
> atomic_set(&kgdb_cpu_doing_single_step, -1);
> --
> 2.23.0
>