From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1] kernel.h: Split out mathematical helpers
Date: Wed, 2 Oct 2019 17:13:37 -0700 [thread overview]
Message-ID: <20191002171337.7cf1f48fde153382d7245fc5@linux-foundation.org> (raw)
In-Reply-To: <20190910105105.7714-1-andriy.shevchenko@linux.intel.com>
On Tue, 10 Sep 2019 13:51:05 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out mathematical
> helpers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> fs/nfs/callback_proc.c | 1 +
> include/linux/bitops.h | 3 +-
> include/linux/dcache.h | 1 +
> include/linux/iommu-helper.h | 1 +
> include/linux/kernel.h | 143 --------------------------------
> include/linux/math.h | 149 ++++++++++++++++++++++++++++++++++
> include/linux/rcu_node_tree.h | 2 +
I'm not really understanding how this works, apart from "dumb luck".
Random example: mm/percpu.c needs roundup(), so how does it include the
new math.h?
....... ./arch/x86/include/asm/uprobes.h
........ ./include/linux/notifier.h
......... ./include/linux/mutex.h
......... ./include/linux/srcu.h
.......... ./include/linux/workqueue.h
........... ./include/linux/timer.h
............ ./include/linux/ktime.h
............. ./include/linux/time.h
.............. ./include/linux/time32.h
............... ./include/linux/timex.h
................ ./include/uapi/linux/timex.h
................. ./include/linux/time.h
................ ./include/uapi/linux/param.h
................. ./arch/x86/include/generated/uapi/asm/param.h
.................. ./include/asm-generic/param.h
................... ./include/uapi/asm-generic/param.h
................ ./arch/x86/include/asm/timex.h
................. ./arch/x86/include/asm/tsc.h
............. ./include/linux/jiffies.h
.............. ./arch/x86/include/generated/uapi/asm/param.h
.............. ./include/generated/timeconst.h
............. ./include/linux/timekeeping.h
............. ./include/linux/timekeeping32.h
............ ./include/linux/debugobjects.h
.......... ./include/linux/rcu_segcblist.h
.......... ./include/linux/srcutree.h
........... ./include/linux/rcu_node_tree.h
............ ./include/linux/math.h
oh, like that.
It seems rather unreliable. Perhaps a "#include <linux/math.h>" was
intended in kernel.h?
next prev parent reply other threads:[~2019-10-03 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 10:51 [PATCH v1] kernel.h: Split out mathematical helpers Andy Shevchenko
2019-10-03 0:13 ` Andrew Morton [this message]
2020-02-04 13:41 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2020-10-28 17:32 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002171337.7cf1f48fde153382d7245fc5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).