From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A494DC10F14 for ; Thu, 3 Oct 2019 07:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76FFE21D71 for ; Thu, 3 Oct 2019 07:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570086375; bh=Z52YU1Rb8AyRAWvQJRdXCtaUHZIoCZ2oPG25QZxyvHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=r1SMw3sM5RhLsYVf/DQZUgqSPTMexSpufN/K2T9srQvcRNahriE7N9E0EdLWRJcsg z1f5YdF4HmgjTYVbuqLB9u1j3emaQbjF5F5c7wMcyD4sKuMI4nt5fZXKseC0fQvqKg KKUwfoQTdrPvR6gVmcgo0hDcPDcHExt+K6lVOwb8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbfJCHGO (ORCPT ); Thu, 3 Oct 2019 03:06:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:38074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbfJCHGO (ORCPT ); Thu, 3 Oct 2019 03:06:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 917DB21848; Thu, 3 Oct 2019 07:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570086373; bh=Z52YU1Rb8AyRAWvQJRdXCtaUHZIoCZ2oPG25QZxyvHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JMkyYz3pcLeMRCJ9cd0+Vo/tTrkE7SOXQBKCNZfeBPfsXHjKacGPD2/C8gE5ORVJ2 dYqiVpKQK/9zOLcvoOcbkS8BsQRPPoHw7KnSX45A/gVUsEc6vv433DzI+s2BiSPdaR bWzJwmYx+rBNs/AJyXP3SUHeCL/LiDcUnl/ivzYo= Date: Thu, 3 Oct 2019 09:06:10 +0200 From: Greg KH To: Murali Nalajala Cc: rafael@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org Subject: Re: [PATCH] base: soc: Handle custom soc information sysfs entries Message-ID: <20191003070610.GC1814133@kroah.com> References: <1570061174-4918-1-git-send-email-mnalajal@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570061174-4918-1-git-send-email-mnalajal@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 02, 2019 at 05:06:14PM -0700, Murali Nalajala wrote: > Soc framework exposed sysfs entries are not sufficient for some > of the h/w platforms. Currently there is no interface where soc > drivers can expose further information about their SoCs via soc > framework. This change address this limitation where clients can > pass their custom entries as attribute group and soc framework > would expose them as sysfs properties. > > Signed-off-by: Murali Nalajala > --- > drivers/base/soc.c | 26 ++++++++++++++++++-------- > include/linux/sys_soc.h | 1 + > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/base/soc.c b/drivers/base/soc.c > index 7c0c5ca..ec70a58 100644 > --- a/drivers/base/soc.c > +++ b/drivers/base/soc.c > @@ -15,6 +15,8 @@ > #include > #include > > +#define NUM_ATTR_GROUPS 3 > + > static DEFINE_IDA(soc_ida); > > static ssize_t soc_info_get(struct device *dev, > @@ -104,11 +106,6 @@ static ssize_t soc_info_get(struct device *dev, > .is_visible = soc_attribute_mode, > }; > > -static const struct attribute_group *soc_attr_groups[] = { > - &soc_attr_group, > - NULL, > -}; > - > static void soc_release(struct device *dev) > { > struct soc_device *soc_dev = container_of(dev, struct soc_device, dev); > @@ -121,6 +118,7 @@ static void soc_release(struct device *dev) > struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr) > { > struct soc_device *soc_dev; > + const struct attribute_group **soc_attr_groups = NULL; > int ret; > > if (!soc_bus_type.p) { > @@ -136,10 +134,20 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr > goto out1; > } > > + soc_attr_groups = kzalloc(sizeof(*soc_attr_groups) * > + NUM_ATTR_GROUPS, GFP_KERNEL); > + if (!soc_attr_groups) { > + ret = -ENOMEM; > + goto out2; > + } > + soc_attr_groups[0] = &soc_attr_group; > + soc_attr_groups[1] = soc_dev_attr->custom_attr_group; > + soc_attr_groups[2] = NULL; > + > /* Fetch a unique (reclaimable) SOC ID. */ > ret = ida_simple_get(&soc_ida, 0, 0, GFP_KERNEL); > if (ret < 0) > - goto out2; > + goto out3; > soc_dev->soc_dev_num = ret; > > soc_dev->attr = soc_dev_attr; > @@ -151,14 +159,16 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr > > ret = device_register(&soc_dev->dev); > if (ret) > - goto out3; > + goto out4; > > return soc_dev; > > -out3: > +out4: > ida_simple_remove(&soc_ida, soc_dev->soc_dev_num); > put_device(&soc_dev->dev); > soc_dev = NULL; > +out3: > + kfree(soc_attr_groups); > out2: > kfree(soc_dev); > out1: > diff --git a/include/linux/sys_soc.h b/include/linux/sys_soc.h > index 48ceea8..d9b3cf0 100644 > --- a/include/linux/sys_soc.h > +++ b/include/linux/sys_soc.h > @@ -15,6 +15,7 @@ struct soc_device_attribute { > const char *serial_number; > const char *soc_id; > const void *data; > + const struct attribute_group *custom_attr_group; Shouldn't you make this: const struct attribute_group **soc_groups; to match up with the rest of the way the driver core works? thanks, greg k-h