From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU
Date: Thu, 3 Oct 2019 10:25:31 -0300 [thread overview]
Message-ID: <20191003132531.GA9369@kernel.org> (raw)
In-Reply-To: <ed9138ac-d035-1be7-9fbd-e82e7f9ca6d0@intel.com>
Em Thu, Oct 03, 2019 at 02:01:16PM +0300, Adrian Hunter escreveu:
> On 6/09/19 11:57 AM, Adrian Hunter wrote:
> > On 21/08/19 11:32 AM, Adrian Hunter wrote:
> >> Hi
> >>
> >> These patches to exported-sql-viewer.py, add a time chart based on context
> >> switch information. Context switch information was added to the database
> >> export fairly recently, so the chart menu option will only appear if
> >> context switch information is in the database. Refer to the Exported SQL
> >> Viewer Help option for more information about the chart.
> >>
> >>
> >> Adrian Hunter (6):
> >> perf scripts python: exported-sql-viewer.py: Add LookupModel()
> >> perf scripts python: exported-sql-viewer.py: Add HBoxLayout and VBoxLayout
> >> perf scripts python: exported-sql-viewer.py: Add global time range calculations
> >> perf scripts python: exported-sql-viewer.py: Tidy up Call tree call_time
> >> perf scripts python: exported-sql-viewer.py: Add ability for Call tree to open at a specified task and time
> >> perf scripts python: exported-sql-viewer.py: Add Time chart by CPU
> >>
> >> tools/perf/scripts/python/exported-sql-viewer.py | 1555 +++++++++++++++++++++-
> >> 1 file changed, 1531 insertions(+), 24 deletions(-)
> >
> > Any comments?
> >
>
> ping
Nice stuff, but please next time, when you add a new UI accessible
visualization, provide precise steps to collect, then generate the DB
and finally run the GUI, so that interested people (like me, when
testing) can follow those instructions and compare the result described
to the graph the test would see following these instructions.
I'm trying to do that now.
- Arnaldo
next prev parent reply other threads:[~2019-10-03 13:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:32 [PATCH 0/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU Adrian Hunter
2019-08-21 8:32 ` [PATCH 1/6] perf scripts python: exported-sql-viewer.py: Add LookupModel() Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-08-21 8:32 ` [PATCH 2/6] perf scripts python: exported-sql-viewer.py: Add HBoxLayout and VBoxLayout Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-08-21 8:32 ` [PATCH 3/6] perf scripts python: exported-sql-viewer.py: Add global time range calculations Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-08-21 8:32 ` [PATCH 4/6] perf scripts python: exported-sql-viewer.py: Tidy up Call tree call_time Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-08-21 8:32 ` [PATCH 5/6] perf scripts python: exported-sql-viewer.py: Add ability for Call tree to open at a specified task and time Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-08-21 8:32 ` [PATCH 6/6] perf scripts python: exported-sql-viewer.py: Add Time chart by CPU Adrian Hunter
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2019-09-06 8:57 ` [PATCH 0/6] " Adrian Hunter
2019-10-03 11:01 ` Adrian Hunter
2019-10-03 13:25 ` Arnaldo Carvalho de Melo [this message]
2019-10-03 13:43 ` Arnaldo Carvalho de Melo
2019-10-04 8:33 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003132531.GA9369@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox