From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43504C32792 for ; Thu, 3 Oct 2019 21:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B93421D71 for ; Thu, 3 Oct 2019 21:05:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h15edSAO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbfJCVF2 (ORCPT ); Thu, 3 Oct 2019 17:05:28 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42532 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfJCVF2 (ORCPT ); Thu, 3 Oct 2019 17:05:28 -0400 Received: by mail-pf1-f194.google.com with SMTP id q12so2499627pff.9 for ; Thu, 03 Oct 2019 14:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EiltBEq6njqGNMiV0WVZrSDJVepz/r4bkWK6+Mlhtls=; b=h15edSAOeAVO6+isDrz0W6jcs1RlAD347T43CXwfP6aj516mFy9O19/PPmYCkrcFAy 8ZZDObjG8qPgpYcPLivDmXHq0y38Rv2EarhS2mGFXA16kD4oew1n/UDzu96ifq0sZWd0 QwgfPrCQlt2u9uAiDHKRaued1dnb7vheuPGGc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EiltBEq6njqGNMiV0WVZrSDJVepz/r4bkWK6+Mlhtls=; b=sGefiKYbPL6xr7tRO6CWXD4gkOn3mEojoubIjkLdzkdnj0Dxwk1alVTAhgpMlsMQSg /BU5qWtqs46YnXiXYpPQ+jdndpdiSAo91JfLY/gAs9OKgnaqTI26rjeLBpvYwTViWcwS FEZEITkCQ1AjsHcLOMsG05yJy3qcgHLY0toOvUHILS/jIsxRbbHAWDiKj6J4SVc8Nd+3 0UgeEoDbQe8glQRvzT7MZaWl7Qa+ISbQo1/JIeGnKZzfOckxCE3yyDRf+D+Dm6kUANtM Rfst+2jMRgh4MNJ68Xn3VGGqpId1JqOpwLk41OTzqC6CD38xZXnBqa99WudWtzvlt4Qd MVRA== X-Gm-Message-State: APjAAAXhZPLKx68RWuzGL2cF7n8ZhlKtvA1lmcry76RiRI5eB5iE3Boy zzQP5qLoqU/WzgR/w2c6bHF7mA== X-Google-Smtp-Source: APXvYqwjSuvsL3+nr1PLtA1rKl85DoBCn/uehIlb3OTXV0Cx3UdB9yBzNVCmiNsnR3ZDRn3AOqIfXg== X-Received: by 2002:a62:3585:: with SMTP id c127mr13074356pfa.18.1570136726099; Thu, 03 Oct 2019 14:05:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y17sm5554361pfo.171.2019.10.03.14.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 14:05:25 -0700 (PDT) Date: Thu, 3 Oct 2019 14:05:24 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Florian Weimer , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Jann Horn , Arnd Bergmann , Helge Deller Subject: Re: [REPOST][RFC][PATCH] sysctl: Remove the sysctl system call Message-ID: <201910031404.C30A0F16@keescook> References: <8736gcjosv.fsf@x220.int.ebiederm.org> <201910011140.EA0181F13@keescook> <87y2y271ws.fsf@mid.deneb.enyo.de> <87tv8pftjj.fsf_-_@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tv8pftjj.fsf_-_@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 03, 2019 at 03:44:32PM -0500, Eric W. Biederman wrote: > > This system call has been deprecated almost since it was introduced, and none > of the common distributions enable it. The only indication that I can find that > anyone might care is that a few of the defconfigs in the kernel enable it. However > that is a small fractions of the defconfigs so I suspect it just a lack of care > rather than a reflection of software using the the sysctl system call. > > As there appear to be no users of the sysctl system call, remove the > code so that the proc filesystem can be simplified. nitpick: line lengths near 80 characters > Signed-off-by: "Eric W. Biederman" But, yes, I would love to see this gone. :) Reviewed-by: Kees Cook -- Kees Cook