From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BADC4360C for ; Fri, 4 Oct 2019 11:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB73220862 for ; Fri, 4 Oct 2019 11:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eDZ+LnQE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731244AbfJDLvD (ORCPT ); Fri, 4 Oct 2019 07:51:03 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36835 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730814AbfJDLvC (ORCPT ); Fri, 4 Oct 2019 07:51:02 -0400 Received: by mail-pf1-f196.google.com with SMTP id y22so3775416pfr.3 for ; Fri, 04 Oct 2019 04:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LDjxN9zYfYwQGavnLYA8WpnuYwjGQxc3ZfqoyY+I8d4=; b=eDZ+LnQEXYZs967EljhFpazUQwxyUnRr8qR/yJ+x3NhXFEjxLwXjpxOsiUBJ78DaKI /UMmcl3MEa8C5DRK+Ei3BqtgIO6FTYRD/5EskT6tIuU4YqyusAUCYOJRZqPQdwu2enYd PIA2NetokHIFO9SSciCIAErYX/HJ9orevIsr117hbKzymnue9yy/3p5cECN/O2PkESTS yGSINmk/SzLffG2biSja81ucIkF79GxNnrTHJs9S6qEgWTECz8xrfr7pAf9FWhNCtYX2 ONA1XdL8wy//pherVLPZyMIOkhWw9L6uw7RivR13h9eSRr2ajhUAGKRgu6C5aSLZ53cG R1nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LDjxN9zYfYwQGavnLYA8WpnuYwjGQxc3ZfqoyY+I8d4=; b=XN4z9jQxL4r0nxmSTjwMPK+k99s55YrIyUlvWP/U5TIRV7xyBQ0mh3qB17hNMTpOWp Ff8KHmzFttVFyhElgkL/M6VDZDsJ7iHfu9ggVffXZyFG5mB2tLGLqk2cyGmrv6sCa6+/ 1e/wwrgxzfJG8X7yHVBF3ePreclK/MPD0HsPXC1s8WKSzNeqNu/5Ak+q738Z2xNGYJct SpNfSxJ2KxTgJr8gF61q4ZFTTcbEKqvb3d2V0C0Kf8awDDkx9w+qgchEk/Ob6pCHhdxp i42lx5wsku6Wdtj7mVSMWfJ+Fek54mu+va0wbDBCiOxyvTxwd+94FEiCULzQ3PBru5e0 7Ybg== X-Gm-Message-State: APjAAAUkmoUbWp2V9Nc5tzafeuSbHA+glcNY+8XHMQ4fqh6570oZlEtm F771QIKdzfsdgewns8tUJWumbkVZXQc= X-Google-Smtp-Source: APXvYqxWE88uDnUENVAwGnB6kBNSopPGvxoHD74Gl2YC8ZBHYCtxnod+sGwQ8qN4JjQgDDUDo1m3ng== X-Received: by 2002:a17:90a:24a8:: with SMTP id i37mr16435220pje.123.1570189861247; Fri, 04 Oct 2019 04:51:01 -0700 (PDT) Received: from google.com ([2620:15c:2cd:202:668d:6035:b425:3a3a]) by smtp.gmail.com with ESMTPSA id u65sm6097605pfu.104.2019.10.04.04.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 04:50:59 -0700 (PDT) Date: Fri, 4 Oct 2019 04:50:57 -0700 From: Michel Lespinasse To: Davidlohr Bueso Cc: akpm@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Davidlohr Bueso Subject: Re: [PATCH 05/11] IB/hfi1: convert __mmu_int_rb to half closed intervals Message-ID: <20191004115057.GA2371@google.com> References: <20191003201858.11666-1-dave@stgolabs.net> <20191003201858.11666-6-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191003201858.11666-6-dave@stgolabs.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 03, 2019 at 01:18:52PM -0700, Davidlohr Bueso wrote: > diff --git a/drivers/infiniband/hw/hfi1/mmu_rb.c b/drivers/infiniband/hw/hfi1/mmu_rb.c > index 14d2a90964c3..fb6382b2d44e 100644 > --- a/drivers/infiniband/hw/hfi1/mmu_rb.c > +++ b/drivers/infiniband/hw/hfi1/mmu_rb.c > @@ -47,7 +47,7 @@ > #include > #include > #include > -#include > +#include > > #include "mmu_rb.h" > #include "trace.h" > @@ -89,7 +89,7 @@ static unsigned long mmu_node_start(struct mmu_rb_node *node) > > static unsigned long mmu_node_last(struct mmu_rb_node *node) > { > - return PAGE_ALIGN(node->addr + node->len) - 1; > + return PAGE_ALIGN(node->addr + node->len); > } May as well rename the function mmu_node_end(). I was worried if it was used anywhere else, but it turned out it's only used when defining the interval tree. I would also suggest moving this function (as well as mmu_node_first) right before its use, rather than just after, which would allow you to also remove the function prototype a few lines earlier. Looks good to me otherwise. Reviewed-by: Michel Lespinasse -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.