From: Andreas Kemnade <andreas@kemnade.info>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hns@goldelico.com
Subject: Re: [PATCH] backlight: lm3630a: fix module aliases
Date: Sat, 5 Oct 2019 20:19:19 +0200 [thread overview]
Message-ID: <20191005201919.013524da@aktux> (raw)
In-Reply-To: <20190911105148.4prmcr2f2r36sgrf@holly.lan>
Hi,
hmm, this bugfix has not arrived in -next or any -fixes branch I am
aware of yet. I hope it is not forgotten...
so a friendly ping.
Regards,
Andreas
On Wed, 11 Sep 2019 11:51:48 +0100
Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On Tue, Sep 10, 2019 at 05:23:59PM +0200, Andreas Kemnade wrote:
> > Devicetree aliases are missing, so that module autoloading
> > does not work properly.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>
> > ---
> > drivers/video/backlight/lm3630a_bl.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> > index 3b45a1733198..9d67c07db2f2 100644
> > --- a/drivers/video/backlight/lm3630a_bl.c
> > +++ b/drivers/video/backlight/lm3630a_bl.c
> > @@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
> > {}
> > };
> >
> > +MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> > +
> > static const struct of_device_id lm3630a_match_table[] = {
> > { .compatible = "ti,lm3630a", },
> > { },
> > };
> >
> > -MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> > +MODULE_DEVICE_TABLE(of, lm3630a_match_table);
> >
> > static struct i2c_driver lm3630a_i2c_driver = {
> > .driver = {
> > --
> > 2.11.0
> >
>
prev parent reply other threads:[~2019-10-05 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 15:23 [PATCH] backlight: lm3630a: fix module aliases Andreas Kemnade
2019-09-11 10:51 ` Daniel Thompson
2019-10-05 18:19 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005201919.013524da@aktux \
--to=andreas@kemnade.info \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox