linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Mat King <mathewk@google.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	gregkh@linuxfoundation.org, rafael@kernel.org,
	Ross Zwisler <zwisler@google.com>,
	Rajat Jain <rajatja@google.com>, Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>
Subject: Re: New sysfs interface for privacy screens
Date: Sun, 6 Oct 2019 12:58:50 +0200	[thread overview]
Message-ID: <20191006105850.GA24605@amd> (raw)
In-Reply-To: <CAL_quvRknSSVvXN3q_Se0hrziw2oTNS3ENNoeHYhvciCRq9Yww@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

On Tue 2019-10-01 10:09:46, Mat King wrote:
> Resending in plain text mode
> 
> I have been looking into adding Linux support for electronic privacy
> screens which is a feature on some new laptops which is built into the
> display and allows users to turn it on instead of needing to use a
> physical privacy filter. In discussions with my colleagues the idea of
> using either /sys/class/backlight or /sys/class/leds but this new
> feature does not seem to quite fit into either of those classes.

Thank you for not trying to push it as a LED ;-).

> I am proposing adding a class called "privacy_screen" to interface
> with these devices. The initial API would be simple just a single
> property called "privacy_state" which when set to 1 would mean that
> privacy is enabled and 0 when privacy is disabled.
> 
> Current known use cases will use ACPI _DSM in order to interface with
> the privacy screens, but this class would allow device driver authors
> to use other interfaces as well.
> 
> Example:
> 
> # get privacy screen state
> cat /sys/class/privacy_screen/cros_privacy/privacy_state # 1: privacy
> enabled 0: privacy disabled
> 
> # set privacy enabled
> echo 1 > /sys/class/privacy_screen/cros_privacy/privacy_state
> 
>  Does this approach seem to be reasonable?

Not really. How does the userland know which displays this will
affect?

This sounds like something that should go through drm drivers,
probably to be selected by xrandr, rather than separate file somewhere
in sysfs.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2019-10-06 10:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 16:09 New sysfs interface for privacy screens Mat King
2019-10-01 16:27 ` Greg KH
2019-10-01 16:42   ` Mat King
2019-10-02  9:30 ` Jani Nikula
2019-10-02 10:24   ` Daniel Thompson
2019-10-02 10:46     ` Jani Nikula
2019-10-02 15:25       ` Mat King
2019-10-03  8:59         ` Jani Nikula
2019-10-03 19:57           ` Mat King
2019-10-07  4:56             ` Rajat Jain
2019-10-07  8:59               ` Jani Nikula
2019-10-07 13:08             ` Sean Paul
2019-10-07 16:19               ` Mat King
2019-10-07 19:31                 ` Rajat Jain
2019-10-07 19:53                   ` Sean Paul
2019-10-08  6:13                 ` Jani Nikula
     [not found]                   ` <CACK8Z6FF1CBmti797sYWS51j-8ag-pSL9RJ2r9NDibXk2M=tEQ@mail.gmail.com>
2019-10-23  0:17                     ` Rajat Jain
2019-10-23  8:39                   ` Daniel Vetter
2019-10-02 15:46 ` Jonathan Corbet
2019-10-02 17:13   ` Mat King
2019-10-03  8:19   ` Jani Nikula
2019-10-03 10:22     ` Daniel Thompson
2019-10-06 11:04       ` Pavel Machek
2019-10-06 16:48         ` Jingoo Han
2019-10-06 20:34       ` Henrique de Moraes Holschuh
2019-10-06 11:00   ` Pavel Machek
2019-10-06 10:58 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191006105850.GA24605@amd \
    --to=pavel@denx.de \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathewk@google.com \
    --cc=rafael@kernel.org \
    --cc=rajatja@google.com \
    --cc=zwisler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).