From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
olsonse@umich.edu
Subject: Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
Date: Sun, 6 Oct 2019 21:07:26 +0200 [thread overview]
Message-ID: <20191006190726.GB237538@kroah.com> (raw)
In-Reply-To: <20191006184903.12089-1-jbi.octave@gmail.com>
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote:
> Capitalize RANGE_mA to fix camelcase check warning.
> Issue reported by checkpatch.pl
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 2 +-
> drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
> drivers/staging/comedi/drivers/dac02.c | 2 +-
> drivers/staging/comedi/range.c | 6 +++---
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 54c091866777..2fc536db203c 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
> +#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
Did you send this patch twice?
Anyway, this is the units "mA", which needs to be "mA" for obvious
reasons. Sorry, checkpatch is wrong in thsi case.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-06 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 18:49 [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Jules Irenge
2019-10-06 19:07 ` Greg KH [this message]
2019-10-07 15:33 ` [PATCH] checkpatch: Improve ignoring CamelCase SI style variants like mA Joe Perches
2019-10-06 21:31 ` [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Al Viro
-- strict thread matches above, loose matches on Subject: below --
2019-10-06 18:48 Jules Irenge
2019-10-06 18:45 Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006190726.GB237538@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olsonse@umich.edu \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox