From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568BCC352AA for ; Mon, 7 Oct 2019 11:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3511E21655 for ; Mon, 7 Oct 2019 11:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbfJGL01 (ORCPT ); Mon, 7 Oct 2019 07:26:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbfJGL00 (ORCPT ); Mon, 7 Oct 2019 07:26:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FE7A30B2502; Mon, 7 Oct 2019 11:26:26 +0000 (UTC) Received: from krava (unknown [10.43.17.61]) by smtp.corp.redhat.com (Postfix) with SMTP id C2C1660A35; Mon, 7 Oct 2019 11:26:24 +0000 (UTC) Date: Mon, 7 Oct 2019 13:26:24 +0200 From: Jiri Olsa To: Changbin Du Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] perf: add support for logging debug messages to file Message-ID: <20191007112624.GG6919@krava> References: <20191004023954.1116-1-changbin.du@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004023954.1116-1-changbin.du@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 07 Oct 2019 11:26:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 10:39:52AM +0800, Changbin Du wrote: > When in TUI mode, it is impossible to show all the debug messages to > console. This make it hard to debug perf issues using debug messages. > This patch adds support for logging debug messages to file to resolve > this problem. > > v3: > o fix a segfault issue. heya, getting segfault for this: [jolsa@krava perf]$ ./perf report -vv 2>out Segmentation fault (core dumped) jirka > v2: > o specific all debug options one time. > > Changbin Du (2): > perf: support multiple debug options separated by ',' > perf: add support for logging debug messages to file > > tools/perf/Documentation/perf.txt | 15 ++-- > tools/perf/util/debug.c | 124 +++++++++++++++++++----------- > 2 files changed, 90 insertions(+), 49 deletions(-) > > -- > 2.20.1 >