Re: [PATCH 12/36] libperf: Add perf_mmap__read_event() function

Arnaldo Carvalho de Melo
2019-10-10T16:07:24Z

Em Thu, Oct 10, 2019 at 05:32:32PM +0200, Jiri Olsa escreveu:
> On Thu, Oct 10, 2019 at 11:47:00AM -0300, Arnaldo Carvalho de Melo wrote:
>
> SNIP
>
> > > diff --git a/tools/perf/lib/include/internal/mmap.h b/tools/perf/lib/include/internal/mmap.h
> > > index ee536c4441bb..b328332b6ccf 100644
> > > --- a/tools/perf/lib/include/internal/mmap.h
> > > +++ b/tools/perf/lib/include/internal/mmap.h
> > > @@ -11,6 +11,7 @@
> > > #define PERF_SAMPLE_MAX_SIZE (1 << 16)
> > >
> > > struct perf_mmap;
> > > +union perf_event;
> >
> > Why are you adding this here?
>
> oops, it should be in lib/include/perf/mmap.h ;-)
> plz let me know if you want me to repost

I fixed it already, its in acme/tmp.perf/core, will continue later,
possibly will push to Ingo what I have there if it passes all the
tests, its getting too big a perf/core. :-)

- Arnaldo