From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97EEECE58C for ; Mon, 7 Oct 2019 13:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B098021835 for ; Mon, 7 Oct 2019 13:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570454950; bh=/ew1iTFSPFJl1GZ94sCBI0f4pcTvUs1Ne8ccMb1v1Pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=trNvw1z78vGH/N3wBOJdeBQHGx6cMvivzNzLayNHsbBNh/wybuFYfhzSic4JbILts y/ciUWIR0iyUgO5gmOLDLTkjlFR5j1cXgFmL4BRWLaKhFe9KpDPPZkh1iC6D0ZuC9W 8iWdgbreFshokZqu3dgJiZ7hgwjXcAGOY5iZUNs4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbfJGN3K (ORCPT ); Mon, 7 Oct 2019 09:29:10 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41439 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728111AbfJGN3I (ORCPT ); Mon, 7 Oct 2019 09:29:08 -0400 Received: by mail-lj1-f194.google.com with SMTP id f5so13652672ljg.8; Mon, 07 Oct 2019 06:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GX+ni17mNRYs8d+zDraCFt5XjyO8QrKC7e0GjBCgxpI=; b=GYD0iOccoMKwNvKs+vEGDYBXRrLp+SB1FXAc/ZYsuKjQ2i0ZwjaXuT8CoUYFznKI4D T54I0D3SzXKD6uDs+fjJAMNkrs6buEszxwtdTGFkfgTo0Z1OnKPieCcClOmqdgDTkl5w YCpTPh7GhUgaqG0SIFMTjHM8trLXLZC4Hms1hjr9Q/lIJ9O4Z3RdOXAJF/9jasFU9miV a9kXYixouTDUHk6JEpcnAFcYFmCJyhjk3zjMCKdQZNLJlqiVHps9FWx7LdkPzuENK4aO ZVOFC1LsJckAuJmNytBLWSrVbOb75IIhCS9abJ2/EHQMbiQzuKRQDc/tsBq7L87HSqkA 1rQA== X-Gm-Message-State: APjAAAXh8Di/GeHuHhKJIXr5aLDS3owF8O94FVo8Fk5/qGMUmcyys/g3 qCLzziAGvaAzipfS8+Otmn8= X-Google-Smtp-Source: APXvYqynuA5BGpbWsgvP1hes+JeGDkBXIl1Dy9tUzl9gPBMvAHVKebDueiFRLgJ0ybXNfKAMNKastg== X-Received: by 2002:a2e:9f4f:: with SMTP id v15mr18952799ljk.222.1570454945399; Mon, 07 Oct 2019 06:29:05 -0700 (PDT) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id f22sm2702245lfk.56.2019.10.07.06.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 06:29:04 -0700 (PDT) From: Ricardo Ribalda Delgado To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v8 3/6] media: ad5820: Add support for enable pin Date: Mon, 7 Oct 2019 15:28:53 +0200 Message-Id: <20191007132856.27948-4-ribalda@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191007132856.27948-1-ribalda@kernel.org> References: <20191007132856.27948-1-ribalda@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds support for a programmable enable pin. It can be used in situations where the ANA-vcc is not configurable (dummy-regulator), or just to have a more fine control of the power saving. The use of the enable pin is optional. Signed-off-by: Ricardo Ribalda Delgado Acked-by: Pavel Machek --- drivers/media/i2c/Kconfig | 2 +- drivers/media/i2c/ad5820.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 78dc64d7b0e7..30d460844dff 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -975,7 +975,7 @@ if MEDIA_CAMERA_SUPPORT config VIDEO_AD5820 tristate "AD5820 lens voice coil support" - depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER + depends on GPIOLIB && I2C && VIDEO_V4L2 && MEDIA_CONTROLLER help This is a driver for the AD5820 camera lens voice coil. It is used for example in Nokia N900 (RX-51). diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c index 7a49651f4d1f..76aab651f217 100644 --- a/drivers/media/i2c/ad5820.c +++ b/drivers/media/i2c/ad5820.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -47,6 +48,8 @@ struct ad5820_device { u32 focus_ramp_time; u32 focus_ramp_mode; + struct gpio_desc *enable_gpio; + struct mutex power_lock; int power_count; @@ -114,6 +117,8 @@ static int ad5820_power_off(struct ad5820_device *coil, bool standby) ret = ad5820_update_hw(coil); } + gpiod_set_value_cansleep(coil->enable_gpio, 0); + ret2 = regulator_disable(coil->vana); if (ret) return ret; @@ -128,6 +133,8 @@ static int ad5820_power_on(struct ad5820_device *coil, bool restore) if (ret < 0) return ret; + gpiod_set_value_cansleep(coil->enable_gpio, 1); + if (restore) { /* Restore the hardware settings. */ coil->standby = false; @@ -138,6 +145,7 @@ static int ad5820_power_on(struct ad5820_device *coil, bool restore) return 0; fail: + gpiod_set_value_cansleep(coil->enable_gpio, 0); coil->standby = true; regulator_disable(coil->vana); @@ -304,6 +312,15 @@ static int ad5820_probe(struct i2c_client *client, return ret; } + coil->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", + GPIOD_OUT_LOW); + if (IS_ERR(coil->enable_gpio)) { + ret = PTR_ERR(coil->enable_gpio); + if (ret != -EPROBE_DEFER) + dev_err(&client->dev, "could not get enable gpio\n"); + return ret; + } + mutex_init(&coil->power_lock); v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops); -- 2.23.0