From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C80C35280 for ; Tue, 8 Oct 2019 16:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9923620815 for ; Tue, 8 Oct 2019 16:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbfJHQMu (ORCPT ); Tue, 8 Oct 2019 12:12:50 -0400 Received: from mga04.intel.com ([192.55.52.120]:42615 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfJHQMt (ORCPT ); Tue, 8 Oct 2019 12:12:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 09:12:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="206667983" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 08 Oct 2019 09:12:47 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iHs6P-0003r1-Mi; Tue, 08 Oct 2019 19:12:45 +0300 Date: Tue, 8 Oct 2019 19:12:45 +0300 From: Andy Shevchenko To: Luis Chamberlain Cc: Tuowen Zhao , lee.jones@linaro.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, acelan.kao@canonical.com, bhelgaas@google.com, kai.heng.feng@canonical.com Subject: Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Message-ID: <20191008161245.GU32742@smile.fi.intel.com> References: <20191007184231.13256-1-ztuowen@gmail.com> <20191008151628.GA16384@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008151628.GA16384@42.do-not-panic.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 08, 2019 at 03:16:28PM +0000, Luis Chamberlain wrote: > On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > > +EXPORT_SYMBOL(devm_ioremap_uc); > > EXPORT_SYMBOL_GPL() would be my preference. Maybe we can even split this to two patches? -- With Best Regards, Andy Shevchenko