From: Roman Gushchin <guro@fb.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Bruce Ashfield <bruce.ashfield@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"Richard Purdie" <richard.purdie@linuxfoundation.org>
Subject: Re: ptrace/strace and freezer oddities and v5.2+ kernels
Date: Tue, 8 Oct 2019 17:27:10 +0000 [thread overview]
Message-ID: <20191008172706.GA9392@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20191008123601.GA28621@redhat.com>
On Tue, Oct 08, 2019 at 02:36:01PM +0200, Oleg Nesterov wrote:
> On 10/08, Bruce Ashfield wrote:
> >
> > So I've been looking through the config delta's and late last night, I was
> > able to move the runtime back to a failed 4 minute state by adding the
> > CONFIG_PREEMPT settings that we have by default in our reference
> > kernel.
Ah, yeah, I don't have CONFIG_PREEMPT on any of my machines.
Good catch, Bruce!
>
> Aha... Can you try the patch below?
>
> Oleg.
>
> --- x/kernel/signal.c
> +++ x/kernel/signal.c
> @@ -2205,8 +2205,8 @@ static void ptrace_stop(int exit_code, int why, int clear_code, kernel_siginfo_t
> */
> preempt_disable();
> read_unlock(&tasklist_lock);
> - preempt_enable_no_resched();
> cgroup_enter_frozen();
> + preempt_enable_no_resched();
> freezable_schedule();
> cgroup_leave_frozen(true);
> } else {
>
That was fast! Thank you, Oleg!
next prev parent reply other threads:[~2019-10-08 17:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 16:14 ptrace/strace and freezer oddities and v5.2+ kernels Bruce Ashfield
2019-10-02 2:01 ` Roman Gushchin
2019-10-02 4:18 ` Bruce Ashfield
2019-10-02 18:19 ` Roman Gushchin
2019-10-02 21:59 ` Bruce Ashfield
2019-10-04 0:09 ` Roman Gushchin
2019-10-07 12:54 ` Bruce Ashfield
2019-10-07 20:11 ` Bruce Ashfield
2019-10-07 23:27 ` Roman Gushchin
2019-10-08 12:13 ` Bruce Ashfield
2019-10-08 12:36 ` Oleg Nesterov
2019-10-08 12:58 ` Bruce Ashfield
2019-10-08 17:27 ` Roman Gushchin [this message]
2019-10-09 15:02 ` [PATCH] cgroup: freezer: call cgroup_enter_frozen() with preemption disabled in ptrace_stop() Oleg Nesterov
2019-10-09 15:21 ` Roman Gushchin
2019-10-11 16:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008172706.GA9392@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=bruce.ashfield@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox