public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chandra Annamaneni <chandra627@gmail.com>
Cc: devel@driverdev.osuosl.org, gneukum1@gmail.com,
	michael.scheiderer@fau.de, fabian.krueger@fau.de,
	linux-kernel@vger.kernel.org, simon@nikanor.nu
Subject: Re: [PATCH] KPC2000: kpc2000_spi.c: Fix alignment and style problems.
Date: Wed, 9 Oct 2019 09:43:34 +0200	[thread overview]
Message-ID: <20191009074334.GA3842746@kroah.com> (raw)
In-Reply-To: <1570593039-19059-1-git-send-email-chandra627@gmail.com>

On Tue, Oct 08, 2019 at 08:50:39PM -0700, Chandra Annamaneni wrote:
> 	Fixed alignment and style issues raised by checkpatch.pl

Why is this padded?

Also, you need to break this up into "one logical change per patch",
you can't "fix all style issues" at once, sorry.

Please fix this up and send it as a patch series.

thanks,

greg k-h

  reply	other threads:[~2019-10-09  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09  3:50 [PATCH] KPC2000: kpc2000_spi.c: Fix alignment and style problems Chandra Annamaneni
2019-10-09  7:43 ` Greg KH [this message]
2019-10-09  7:57 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191009074334.GA3842746@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chandra627@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabian.krueger@fau.de \
    --cc=gneukum1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.scheiderer@fau.de \
    --cc=simon@nikanor.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox