Re: [PATCH] si2157: Add support for Logilink VG0022A.

Sean Young
2019-10-02T15:06:53Z

On Wed, Oct 02, 2019 at 04:44:24PM +0200, Gonsolo wrote:
> Hi!
>
> > You need a message and a Signed-off-by: here.
>
> Ok, I'll try to get that right the next time.
>
> > > + ret = si2157_power_up(dev, client);
> > > + if (ret)
> > > + goto err;
> > > + /* query chip revision */
> > > + /* hack: do it here because after the si2168 gets 0101, commands will
> > > + * still be executed here but no result
> >
> > I don't understand. What problem are you seeing here? Why can't you do a
> > query chip revision first?
>
> This was explained here: https://lkml.org/lkml/2017/3/15/778. To quote:

Antti has some great suggestions in that thread:
https://lkml.org/lkml/2017/5/24/245

Also note https://lkml.org/lkml/2017/5/26/357 if you have access to a
logic analyser.

Sean