From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95004C10F14 for ; Thu, 10 Oct 2019 08:40:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FBE220B7C for ; Thu, 10 Oct 2019 08:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570696834; bh=AYCAce8R8+1AGpgdpdakmyUkNlhCjR6dQ3fDZMXkhHI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gFOTLJSD9APsUaMjjRgbt+FHEUhVSapKvSAPcvZVq6BAI+StKox/0q18Ml3oMFQtc SHwSmW/2HqbHLYATBTiVTyQc8ySPZaJqUcPfNVj2kjSsYVd0BcbrLNlnlCXmgTYBWR SnOWuavIyqwEriJ4ZRJPsJgdkc234Row508YPjdM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388128AbfJJIkc (ORCPT ); Thu, 10 Oct 2019 04:40:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:44606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387493AbfJJIka (ORCPT ); Thu, 10 Oct 2019 04:40:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9749720B7C; Thu, 10 Oct 2019 08:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570696830; bh=AYCAce8R8+1AGpgdpdakmyUkNlhCjR6dQ3fDZMXkhHI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j4+fRh/t7nN9GpBhYpv1raWa92g8DzlzxFv3WoiUFp6yHeeYOPvO1EJq5k/kZBtGB QEcWZRLI4jWVqQiu+Urz6mEea64I7hEP5ucrIgW1ZoFSfkdatUGPzt99opcTnDqU+t zWQewcrtARCMHnhE8GZtRUJGZ/N8CfCmz0LHs+sk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sibi Sankar , Sean Paul , Rob Clark Subject: [PATCH 5.3 067/148] drm/msm/dsi: Fix return value check for clk_get_parent Date: Thu, 10 Oct 2019 10:35:28 +0200 Message-Id: <20191010083615.502085657@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083609.660878383@linuxfoundation.org> References: <20191010083609.660878383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Paul commit 5fb9b797d5ccf311ae4aba69e86080d47668b5f7 upstream. clk_get_parent returns an error pointer upon failure, not NULL. So the checks as they exist won't catch a failure. This patch changes the checks and the return values to properly handle an error pointer. Fixes: c4d8cfe516dc ("drm/msm/dsi: add implementation for helper functions") Cc: Sibi Sankar Cc: Sean Paul Cc: Rob Clark Cc: # v4.19+ Signed-off-by: Sean Paul Signed-off-by: Rob Clark Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/msm/dsi/dsi_host.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -421,15 +421,15 @@ static int dsi_clk_init(struct msm_dsi_h } msm_host->byte_clk_src = clk_get_parent(msm_host->byte_clk); - if (!msm_host->byte_clk_src) { - ret = -ENODEV; + if (IS_ERR(msm_host->byte_clk_src)) { + ret = PTR_ERR(msm_host->byte_clk_src); pr_err("%s: can't find byte_clk clock. ret=%d\n", __func__, ret); goto exit; } msm_host->pixel_clk_src = clk_get_parent(msm_host->pixel_clk); - if (!msm_host->pixel_clk_src) { - ret = -ENODEV; + if (IS_ERR(msm_host->pixel_clk_src)) { + ret = PTR_ERR(msm_host->pixel_clk_src); pr_err("%s: can't find pixel_clk clock. ret=%d\n", __func__, ret); goto exit; }