From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88AAFC4360C for ; Thu, 10 Oct 2019 09:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F82A2067B for ; Thu, 10 Oct 2019 09:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570698064; bh=8Zflg7lZGju3znOPM11CWJ5ivnYcOP2oM1Gv3T3aW9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Uf6L8k9wz9mBMWeTVTwa5nfuEyLlGqqLi7f5hY1Hvi8yOV4kPtDtFFWXi4wVDP9k/ KNGUtcGk9FqYjxPqNRXN/2wglePZELLFJqFqvmyJBWmRhSk4G7904GPe4+2i1LTiyB rtfgcvqNkZ+JWDrHvNx/pNLUvfNWEk1EAe8FuRSg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388453AbfJJImA (ORCPT ); Thu, 10 Oct 2019 04:42:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:46408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388411AbfJJIlw (ORCPT ); Thu, 10 Oct 2019 04:41:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E6802054F; Thu, 10 Oct 2019 08:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570696912; bh=8Zflg7lZGju3znOPM11CWJ5ivnYcOP2oM1Gv3T3aW9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JuoItyXtBDpl+MsVf+au2XXu+aTcSNuGVPGWf9uGYCJlQkEPAvBQB7Ad4VBr8KnWL nShsFiYIhXy+21pzzTDdoHqXAZHvnkMBdcRFOrFB9f7q/nw8icyKICfrwf7ZZHXwO/ tienev9MqaoZ2iUoR+AIV0BTMWKqH0sQMl/6xHv0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "H. Nikolaus Schaller" , Tony Lindgren Subject: [PATCH 5.3 081/148] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again Date: Thu, 10 Oct 2019 10:35:42 +0200 Message-Id: <20191010083616.242624592@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083609.660878383@linuxfoundation.org> References: <20191010083609.660878383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: H. Nikolaus Schaller commit f1f028ff89cb0d37db299d48e7b2ce19be040d52 upstream. commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings" did introduce logic to centrally handle the legacy spi-cs-high property in combination with cs-gpios. This assumes that the polarity of the CS has to be inverted if spi-cs-high is missing, even and especially if non-legacy GPIO_ACTIVE_HIGH is specified. The DTS for the GTA04 was orginally introduced under the assumption that there is no need for spi-cs-high if the gpio is defined with proper polarity GPIO_ACTIVE_HIGH. This was not a problem until gpiolib changed the interpretation of GPIO_ACTIVE_HIGH and missing spi-cs-high. The effect is that the missing spi-cs-high is now interpreted as CS being low (despite GPIO_ACTIVE_HIGH) which turns off the SPI interface when the panel is to be programmed by the panel driver. Therefore, we have to add the redundant and legacy spi-cs-high property to properly activate CS. Cc: stable@vger.kernel.org Signed-off-by: H. Nikolaus Schaller Signed-off-by: Tony Lindgren Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/omap3-gta04.dtsi | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi @@ -120,6 +120,7 @@ spi-max-frequency = <100000>; spi-cpol; spi-cpha; + spi-cs-high; backlight= <&backlight>; label = "lcd";