RE: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

Matt Sickler
2019-10-10T14:55:45Z

>-----Original Message-----
>From: devel <driverdev-devel-bounces@linuxdriverproject.org> On Behalf Of Chandra Annamaneni
>Sent: Wednesday, October 09, 2019 10:09 PM
>To: gregkh@linuxfoundation.org
>Cc: devel@driverdev.osuosl.org; gneukum1@gmail.com; chandra627@gmail.com; fabian.krueger@fau.de; linux-
>kernel@vger.kernel.org; simon@nikanor.nu; dan.carpenter@oracle.com
>Subject: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
>
>Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
>Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
>---
> drivers/staging/kpc2000/kpc2000_spi.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
>index 3be33c4..ef78b6d 100644
>--- a/drivers/staging/kpc2000/kpc2000_spi.c
>+++ b/drivers/staging/kpc2000/kpc2000_spi.c
>@@ -30,19 +30,19 @@
> #include "kpc.h"
>
> static struct mtd_partition p2kr0_spi0_parts[] = {
>- { .name = "SLOT_0", .size = 7798784, .offset = 0, },
>- { .name = "SLOT_1", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_2", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_3", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_0", .size = 7798784, .offset = 0,},
>+ { .name = "SLOT_1", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_2", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_3", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> };
>
> static struct mtd_partition p2kr0_spi1_parts[] = {
>- { .name = "SLOT_4", .size = 7798784, .offset = 0, },
>- { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>- { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_4", .size = 7798784, .offset = 0,},
>+ { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> };
>
> static struct flash_platform_data p2kr0_spi0_pdata = {

Is the line length limit a hard rule or can exceptions be made? I really feel that these data tables are more easily read when they're formatted like tables...