Re: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

Dan Carpenter
2019-10-11T10:02:52Z

On Thu, Oct 10, 2019 at 02:54:59PM +0000, Matt Sickler wrote:
> > static struct mtd_partition p2kr0_spi1_parts[] = {
> >- { .name = "SLOT_4", .size = 7798784, .offset = 0, },
> >- { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >- { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >- { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >- { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_4", .size = 7798784, .offset = 0,},
> >+ { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset = MTDPART_OFS_NXTBLK},
> > };
> >
> > static struct flash_platform_data p2kr0_spi0_pdata = {
>
> Is the line length limit a hard rule or can exceptions be made? I
> really feel that these data tables are more easily read when they're
> formatted like tables...

Exceptions can be made. It's probably not worth it though because
you have to be really aggressive about shooting down patches. Ask
yourself if there aren't more important battles to fight when human
lifespans are so short? I already rejected one change for you. To me
the new table looks okay, though.

regards,
dan carpenter