From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: add support for the cc1101 RF transceiver chip from TI
Date: Fri, 11 Oct 2019 08:43:42 +0200 [thread overview]
Message-ID: <20191011064342.GA1045420@kroah.com> (raw)
In-Reply-To: <20190922060356.58763-3-hs@denx.de>
On Sun, Sep 22, 2019 at 08:03:56AM +0200, Heiko Schocher wrote:
> +struct __attribute__ ((packed)) msg_queue_user {
> + int type; /* CC1101_MSG_SET_ */
> +};
> +
> +/* CC1101_MSG_DEFINE_CONFIG */
> +struct __attribute__ ((packed)) config_param {
> + char addr;
> + char val;
> +};
{sigh}
None of these structures are valid ones to be passing to/from
userspace/kernel at all. Please fix them up to work properly (i.e. use
the correct types and such). I think there's a "how to write a correct
ioctl" document in the documentation directory somewhere, you might want
to search for that.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-11 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 6:03 [PATCH 0/2] misc: add support for the cc1101 RF transceiver chip from TI Heiko Schocher
2019-09-22 6:03 ` [PATCH 1/2] misc: add cc1101 devicetree binding Heiko Schocher
2019-10-02 14:19 ` Rob Herring
2019-10-03 5:21 ` Heiko Schocher
2019-09-22 6:03 ` [PATCH 2/2] misc: add support for the cc1101 RF transceiver chip from TI Heiko Schocher
2019-10-11 6:43 ` Greg Kroah-Hartman [this message]
2019-10-16 4:44 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011064342.GA1045420@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=hs@denx.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox