Re: [PATCH 05/19] EDAC, mc: Reduce indentation level in edac_mc_handle_error()

Joe Perches
2019-10-11T10:50:29Z

On Fri, 2019-10-11 at 07:20 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 10 Oct 2019 15:10:53 -0700
> Joe Perches <joe@perches.com> escreveu:
>
> > On Thu, 2019-10-10 at 20:25 +0000, Robert Richter wrote:
> > > Reduce the indentation level in edac_mc_handle_error() a bit by using
> > > continue. No functional changes.
> >
> > Seems fine, but trivially below:
> >
> > > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> > []
> > > @@ -1171,37 +1171,38 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type,
> > []
> > > + strcpy(p, dimm->label);
> > > + p += strlen(p);
> > > + *p = '\0';
> >
> > This *p = '\0' is unnecessary as the strcpy already did that.
>
> True, but better to put it on a separate patch, as it makes
> easier to review if you don't mix code de-indent with changes.
>
> Also, maybe there are other occurrences of this pattern.

Maybe 80 or so uses of paired

strcpy(foo, bar);
strlen(foo)

where another function like stpcpy, which doesn't exist
in the kernel, could have been used.