Re: [PATCH 15/19] EDAC, ghes: Use standard kernel macros for page calculations

Mauro Carvalho Chehab
2019-10-11T11:10:43Z

Em Thu, 10 Oct 2019 20:25:35 +0000
Robert Richter <rrichter@marvell.com> escreveu:

> Use standard macros for page calculations.
>
> Reviewed-by: James Morse <james.morse@arm.com>
> Signed-off-by: Robert Richter <rrichter@marvell.com>

Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

> ---
> drivers/edac/ghes_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 8078d4ec9631..851aad92e42d 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -309,8 +309,8 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err)
>
> /* Error address */
> if (mem_err->validation_bits & CPER_MEM_VALID_PA) {
> - e->page_frame_number = mem_err->physical_addr >> PAGE_SHIFT;
> - e->offset_in_page = mem_err->physical_addr & ~PAGE_MASK;
> + e->page_frame_number = PHYS_PFN(mem_err->physical_addr);
> + e->offset_in_page = offset_in_page(mem_err->physical_addr);
> }
>
> /* Error grain */

Thanks,
Mauro