From: Wambui Karuga <wambui.karugax@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t
Date: Fri, 11 Oct 2019 12:26:52 +0300 [thread overview]
Message-ID: <20191011092652.GB10328@wambui> (raw)
In-Reply-To: <20191011090213.GB1076760@kroah.com>
On Fri, Oct 11, 2019 at 11:02:13AM +0200, Greg KH wrote:
> On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote:
> > -typedef union {
> > +union cvmx_helper_link_info_t {
>
> I agree with Julia, all of the "_t" needs to be dropped as that is
> pointless. It's a holdover from the original name where "_t" was trying
> to say that this is a typedef. Gotta love abuse of hungarian notation
> :(
>
> Please redo this patch series and resend.
>
Great, I'll send an updated patch.
Thanks,
Wambui
next prev parent reply other threads:[~2019-10-11 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 6:02 [PATCH 0/5] Remove declarations of new typedef in Wambui Karuga
2019-10-11 6:02 ` [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t Wambui Karuga
2019-10-11 6:18 ` [Outreachy kernel] " Julia Lawall
2019-10-11 8:59 ` Wambui Karuga
2019-10-11 10:58 ` Dan Carpenter
2019-10-11 6:02 ` [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t Wambui Karuga
2019-10-11 9:02 ` Greg KH
2019-10-11 9:26 ` Wambui Karuga [this message]
2019-10-11 6:02 ` [PATCH 3/5] staging: octeon: remove typedef declaration for cvmx_fau_reg_32_t Wambui Karuga
2019-10-11 6:02 ` [PATCH 4/5] staging: octeon: remove typedef declartion for cvmx_pko_command_word0_t Wambui Karuga
2019-10-11 6:02 ` [PATCH 5/5] staging: octeon: remove typedef declaration for cvmx_fau_op_size_t Wambui Karuga
2019-10-11 9:01 ` [PATCH 0/5] Remove declarations of new typedef in Greg KH
2019-10-11 9:24 ` Wambui Karuga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011092652.GB10328@wambui \
--to=wambui.karugax@gmail.com \
--cc=20191011090213.GB1076760@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox