public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: yu kuai <yukuai3@huawei.com>
Cc: darrick.wong@oracle.com, bfoster@redhat.com, dchinner@redhat.com,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhengbin13@huawei.com, yi.zhang@huawei.com,
	zhangxiaoxu5@huawei.com
Subject: Re: [PATCH] xfs: fix wrong struct type in ioctl definition whih cmd XFS_IOC_GETBMAPAX
Date: Fri, 11 Oct 2019 06:06:15 -0700	[thread overview]
Message-ID: <20191011130615.GA27614@infradead.org> (raw)
In-Reply-To: <1570792486-84374-1-git-send-email-yukuai3@huawei.com>

On Fri, Oct 11, 2019 at 07:14:46PM +0800, yu kuai wrote:
> ioctl expect 'getbmapx' as the 'arg' when the cmd is XFS_IOC_GETBMAPX.
> But the definition in 'xfs_fs.h' is 'getbmap'

Strictly speaking that is true.  But changing this defintion will break
existing userspace given that _IOWR encodes the structure size.  If you
had reported this 16 years earlier we could have fixed it.

  reply	other threads:[~2019-10-11 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 11:14 [PATCH] xfs: fix wrong struct type in ioctl definition whih cmd XFS_IOC_GETBMAPAX yu kuai
2019-10-11 13:06 ` Christoph Hellwig [this message]
2019-10-21  8:29 ` [xfs] eb787bfed8: xfstests.xfs.281.fail kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011130615.GA27614@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox