From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30C1C4360C for ; Sun, 13 Oct 2019 01:03:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3EC32089C for ; Sun, 13 Oct 2019 01:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="sh79Ynuw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbfJMBDp (ORCPT ); Sat, 12 Oct 2019 21:03:45 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41709 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbfJMBDp (ORCPT ); Sat, 12 Oct 2019 21:03:45 -0400 Received: by mail-pg1-f196.google.com with SMTP id t3so7953117pga.8 for ; Sat, 12 Oct 2019 18:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=kj6eOXZz9GyQzhMyxuS7LgKCMI4y1lGlpAkLU4/acCY=; b=sh79YnuwBmmzt0+oeett/u6RA1B5Ow7WccpIoBrSKJt0nJlAcA4BubKO0ua7RqJlA/ aCeege/U/RrMZZhfdhbN0Db6xzVqnzKaetqDlMlGR3pMCSpVdiFuioSuA57QpPEsLjae nmkGKqpMFOH9Ml0a8rE7XvulC/nt2adRvno34vMzzZd9aLN0+DaqZI9yO+jYCMnk7hAb sBmoNhTFEH+rKAcTkmSpCvcHDiQLOKAlSp4ffm2vZeNRqQflZ5tuEukfj8gF7igf+C36 LbofJpYwihJlIVLkrG8GXB7JA5FIIKzS6b+zKHsXWIlrmMQ/DOstuj9z9jKto++tngU9 VE+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=kj6eOXZz9GyQzhMyxuS7LgKCMI4y1lGlpAkLU4/acCY=; b=Z3Kjs1CIwdxcdlKPk/eyxEh3A5B/Rf0v81DLHKiU4nNTsKKH2bBzv9W8svAqqlb6DO S7l/Ja9iJdBOmJoiSDJwjV3IXjYQmBNqLe30oWKUjM48wr62dCPmuZpj6jOnYBbOGH4J wRy0G/74+XL69uEtkpLVfXRO2ax0ciL1VBqmjfPSTKXrp5cBksYZHIK4nqqSNAKTdxts KdxDOY490NtPo3m3FXKQxLJXpmu2UzXWWAGaium8AoW+9Zr3kjlhj++rXEDV9VhfKiox veidq8PIxx2s/uuBKircA1F2PJJwAodOGw3qTyFAc6q6/AISsW0W9qL+XsCpAQ1vcSxc tX+g== X-Gm-Message-State: APjAAAVOjStjqayRnjfnav/0mpC8SPHDCZbQXDIZqFqW8zlOB03sUmM7 h+lAMc+CBi9jilOwpYaCPXhL5A== X-Google-Smtp-Source: APXvYqzWRhONGqr+742j1q1YF4UpoLk477iFpwGfBuVaqsKV6+n3NDsqxg3+RRJkvkuIdACsB32QpQ== X-Received: by 2002:a17:90a:fb92:: with SMTP id cp18mr27517836pjb.2.1570928624428; Sat, 12 Oct 2019 18:03:44 -0700 (PDT) Received: from cakuba.netronome.com ([2601:646:8e00:e18::2]) by smtp.gmail.com with ESMTPSA id q76sm29768368pfc.86.2019.10.12.18.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2019 18:03:44 -0700 (PDT) Date: Sat, 12 Oct 2019 18:03:40 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: Anson Huang , Andy Duan , "davem@davemloft.net" , "gregkh@linuxfoundation.org" , "andy.shevchenko@gmail.com" , "rafael.j.wysocki@intel.com" , "swboyd@chromium.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message Message-ID: <20191012180340.57e5fbfb@cakuba.netronome.com> In-Reply-To: References: <1570616148-11571-1-git-send-email-Anson.Huang@nxp.com> <20191010160811.7775c819@cakuba.netronome.com> <20191010173246.2cd02164@cakuba.netronome.com> <20191010175320.1fe5f6b3@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Oct 2019 12:55:20 +0300, Vladimir Oltean wrote: > > > Unfortunately the networking subsystem sees around a 100 patches > > > submitted each day, it'd be very hard to keep track of patches which have > > > external dependencies and when to merge them. That's why we need the > > > submitters to do this work for us and resubmit when the patch can be > > > applied cleanly. > > > > OK, I will resend this patch series once the necessary patch lands > > on the network tree. > > What has not been mentioned is that you can't create future > dependencies for patches which have a Fixes: tag. > > git describe --tags 7723f4c5ecdb # driver core: platform: Add an error > message to platform_get_irq*() > v5.3-rc1-13-g7723f4c5ecdb > > git describe --tags f1da567f1dc # driver core: platform: Add > platform_get_irq_byname_optional() > v5.4-rc1-46-gf1da567f1dc1 Ack, you raise some good points. AFAIU tho, in this case broken patch, the dependency, and the fix are all targeting 5.4, so there will be no real backporting hassle, while the presence of a Fixes tag makes it clear where the regression was introduced.