Re: [PATCH net 2/2] vhost/vsock: don't allow half-closed socket in the host

Stefano Garzarella
2019-10-11T14:39:36Z

On Fri, Oct 11, 2019 at 10:26:34AM -0400, Michael S. Tsirkin wrote:
> On Fri, Oct 11, 2019 at 03:07:58PM +0200, Stefano Garzarella wrote:
> > vmci_transport never allowed half-closed socket on the host side.
> > In order to provide the same behaviour, we changed the
> > vhost_transport_stream_has_data() to return 0 (no data available)
> > if the peer (guest) closed the connection.
> >
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>
> I don't think we should copy bugs like this.
> Applications don't actually depend on this VMCI limitation, in fact
> it looks like a working application can get broken by this.
>
> So this looks like a userspace visible ABI change
> which we can't really do.
>
> If it turns out some application cares, it can always
> fully close the connection. Or add an ioctl so the application
> can find out whether half close works.
>

I got your point.
Discard this patch.

Thanks,
Stefano