From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Jason Wang <jasowang@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/virtio: Fix build
Date: Sun, 13 Oct 2019 08:20:46 -0400 [thread overview]
Message-ID: <20191013081541-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <08c1e081-765b-7c3a-ed31-2059dc521fd0@web.de>
On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
> On 13.10.19 13:52, Michael S. Tsirkin wrote:
> > On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Various changes in the recent kernel versions broke the build due to
> >> missing function and header stubs.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Thanks!
> > I think it's already fixes in the vhost tree.
> > That tree also includes a bugfix for the test.
> > Can you pls give it a spin and report?
>
> Mostly fixed: the xen_domain stup is missing.
>
> Jan
That's in xen/xen.h. Do you still see any build errors?
> > Thanks!
> >
> >> ---
> >> tools/virtio/crypto/hash.h | 0
> >> tools/virtio/linux/dma-mapping.h | 2 ++
> >> tools/virtio/linux/kernel.h | 2 ++
> >> 3 files changed, 4 insertions(+)
> >> create mode 100644 tools/virtio/crypto/hash.h
> >>
> >> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
> >> new file mode 100644
> >> index 000000000000..e69de29bb2d1
> >> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
> >> index f91aeb5fe571..db96cb4bf877 100644
> >> --- a/tools/virtio/linux/dma-mapping.h
> >> +++ b/tools/virtio/linux/dma-mapping.h
> >> @@ -29,4 +29,6 @@ enum dma_data_direction {
> >> #define dma_unmap_single(...) do { } while (0)
> >> #define dma_unmap_page(...) do { } while (0)
> >>
> >> +#define dma_max_mapping_size(d) 0
> >> +
> >> #endif
> >> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> >> index 6683b4a70b05..ccf321173210 100644
> >> --- a/tools/virtio/linux/kernel.h
> >> +++ b/tools/virtio/linux/kernel.h
> >> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
> >> #define list_for_each_entry(a, b, c) while (0)
> >> /* end of stubs */
> >>
> >> +#define xen_domain() 0
> >> +
> >> #endif /* KERNEL_H */
> >> --
> >> 2.16.4
next prev parent reply other threads:[~2019-10-13 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 9:03 [PATCH] tools/virtio: Fix build Jan Kiszka
2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:20 ` Michael S. Tsirkin [this message]
2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:39 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2022-07-05 7:22 [PATCH] tools/virtio: fix build Stefano Garzarella
2022-07-06 6:39 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013081541-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox