From: Lee Jones <lee.jones@linaro.org>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, daniel.thompson@linaro.org, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com
Subject: Re: [PATCH v7 5/5] backlight: add led-backlight driver
Date: Mon, 14 Oct 2019 08:57:25 +0100 [thread overview]
Message-ID: <20191014075725.GI4545@dell> (raw)
In-Reply-To: <cef282ee-3659-3bc3-da25-db02f843d61c@ti.com>
On Fri, 04 Oct 2019, Jean-Jacques Hiblot wrote:
> Hi Lee,
>
> On 04/10/2019 16:39, Lee Jones wrote:
> > On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
> >
> > > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > >
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > ---
> > > drivers/video/backlight/Kconfig | 7 +
> > > drivers/video/backlight/Makefile | 1 +
> > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++
> > > 3 files changed, 268 insertions(+)
> > > create mode 100644 drivers/video/backlight/led_bl.c
> > Applied, thanks.
>
> It will break the build because it relies on functions not yet in the LED
> core (devm_led_get() for v7 or devm_of_led_get() for v8)
You're right, un-applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-10-14 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:57 [PATCH v7 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-09-18 14:57 ` [PATCH v7 1/5] leds: populate the device's of_node when possible Jean-Jacques Hiblot
2019-09-24 21:03 ` Jacek Anaszewski
2019-10-02 13:58 ` Jean-Jacques Hiblot
2019-10-02 19:47 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-09-24 21:08 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-09-24 21:10 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-04 14:38 ` Lee Jones
2019-09-18 14:57 ` [PATCH v7 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-10-04 14:39 ` Lee Jones
2019-10-04 15:49 ` Jean-Jacques Hiblot
2019-10-14 7:57 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014075725.GI4545@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox