From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4FDECE587 for ; Mon, 14 Oct 2019 07:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C615020854 for ; Mon, 14 Oct 2019 07:57:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EFZRMeDa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730020AbfJNH5a (ORCPT ); Mon, 14 Oct 2019 03:57:30 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35975 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbfJNH5a (ORCPT ); Mon, 14 Oct 2019 03:57:30 -0400 Received: by mail-wr1-f68.google.com with SMTP id y19so18483417wrd.3 for ; Mon, 14 Oct 2019 00:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wlueTYL+8qZ9KSvaC2J4g2+SKGmj7tj869xGKKDwlhM=; b=EFZRMeDamau/PtjDTr3QllzMuLdqjBy/NYciSuFN+qIKgsX0Ot88ouA4V4VQ6UOMQG rWcI4kDhiK/io9dxf0zDYfHtSar7xjwL5WQEmucaF+ZqA2yfOGgkG8MlP4eq8kYcYh6M BV2DH+dladA+Iwa/7WEfoQWfy5qiHAzjwQP36mGz/BOraRyD/CEjY8f3SjfBYhYHafeo 3Y8ostev2sEjqCZQ75hoFrs+xlgITGw50ztSPEyHM6GZprKYHasX7j9i5s5o+UIcbCB+ Zv1gq2qmSvnoO7wpK3/3tyJGIUuBRXfHCXi/FCDYEkw/P4cXcx/KgDIBfW+E8PittOnW iSQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wlueTYL+8qZ9KSvaC2J4g2+SKGmj7tj869xGKKDwlhM=; b=j8+OTBNcqRXCOM0fjqo0RESrEUtaOsjS3rzj7KeDDr6RiIpAZ0BdU2eifSFr6VppLk m354+Wu7nMt7vMUMRHyK5xIx7uKgdYTi/fD77WzT+XQa7mfflyJZ2s9Hb15gQIjTy9ak H8hFIplI1aJ3SgH+7bak3/BdboRBrY4Jw/JoXjPxqTGdx8Jk+zOnpv3sccL0Dk+luuKR etQ0Rx8Fx2JtclRpCfGWG2q/EOBbgE9obGw+75BEHJ6BfMuAMVuDsvxvJISekbgvn1TK vt7lS9zXJo0vhk41j8Kdc44iYBGxJecjv1VeDGi8YmVvsgVrJ+HCZEi+QFKM1vPG3RBR 5qcQ== X-Gm-Message-State: APjAAAWdYp/r6x6zlew4bBZRqIBKD5A1E50X81+WfR/tY6mWVo9ZekSh cgd+vAXFN9b3X8K8kkSbs9+LDw== X-Google-Smtp-Source: APXvYqz1dQ+ediHiuUw3Ev4YeRHAcaUSBjOankgR/wtJRQ2BlmnBskvUcofomJfjQciB18XzBY6BAA== X-Received: by 2002:adf:f5c2:: with SMTP id k2mr26018100wrp.0.1571039847065; Mon, 14 Oct 2019 00:57:27 -0700 (PDT) Received: from dell ([2.27.167.11]) by smtp.gmail.com with ESMTPSA id r2sm39324299wma.1.2019.10.14.00.57.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 00:57:26 -0700 (PDT) Date: Mon, 14 Oct 2019 08:57:25 +0100 From: Lee Jones To: Jean-Jacques Hiblot Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, daniel.thompson@linaro.org, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com Subject: Re: [PATCH v7 5/5] backlight: add led-backlight driver Message-ID: <20191014075725.GI4545@dell> References: <20190918145730.22805-1-jjhiblot@ti.com> <20190918145730.22805-6-jjhiblot@ti.com> <20191004143900.GO18429@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Oct 2019, Jean-Jacques Hiblot wrote: > Hi Lee, > > On 04/10/2019 16:39, Lee Jones wrote: > > On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: > > > > > From: Tomi Valkeinen > > > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > --- > > > drivers/video/backlight/Kconfig | 7 + > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > Applied, thanks. > > It will break the build because it relies on functions not yet in the LED > core (devm_led_get() for v7 or devm_of_led_get() for v8) You're right, un-applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog