From: Peter Zijlstra <peterz@infradead.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Waiman Long <longman@redhat.com>,
1vier1@web.de, Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 2/6] ipc/mqueue.c: Remove duplicated code
Date: Mon, 14 Oct 2019 14:37:28 +0200 [thread overview]
Message-ID: <20191014123728.GE2328@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191012054958.3624-3-manfred@colorfullife.com>
On Sat, Oct 12, 2019 at 07:49:54AM +0200, Manfred Spraul wrote:
> +static inline void __pipelined_op(struct wake_q_head *wake_q,
> struct mqueue_inode_info *info,
> + struct ext_wait_queue *this)
> {
> + list_del(&this->list);
> + wake_q_add(wake_q, this->task);
> /*
> * Rely on the implicit cmpxchg barrier from wake_q_add such
> * that we can ensure that updating receiver->state is the last
> @@ -937,7 +932,19 @@ static inline void pipelined_send(struct wake_q_head *wake_q,
> * yet, at that point we can later have a use-after-free
> * condition and bogus wakeup.
> */
> + this->state = STATE_READY;
^^^^^^^^^^ whitespace damage
> +}
next prev parent reply other threads:[~2019-10-14 12:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 5:49 [PATCH 0/6] V2: Clarify/standardize memory barriers for ipc Manfred Spraul
2019-10-12 5:49 ` [PATCH 1/6] wake_q: Cleanup + Documentation update Manfred Spraul
2019-10-14 6:34 ` Davidlohr Bueso
2019-10-14 12:04 ` Peter Zijlstra
2019-10-12 5:49 ` [PATCH 2/6] ipc/mqueue.c: Remove duplicated code Manfred Spraul
2019-10-14 6:35 ` Davidlohr Bueso
2019-10-14 12:37 ` Peter Zijlstra [this message]
2019-10-12 5:49 ` [PATCH 3/6] ipc/mqueue.c: Update/document memory barriers Manfred Spraul
2019-10-14 6:38 ` Davidlohr Bueso
2019-10-14 12:59 ` Peter Zijlstra
2019-10-14 13:58 ` Peter Zijlstra
2019-10-14 18:06 ` Manfred Spraul
2019-10-12 5:49 ` [PATCH 4/6] ipc/msg.c: Update and document " Manfred Spraul
2019-10-12 5:49 ` [PATCH 5/6] ipc/sem.c: Document and update " Manfred Spraul
2019-10-12 5:49 ` [PATCH 6/6] Documentation/memory-barriers.txt: Clarify cmpxchg() Manfred Spraul
2019-10-14 13:03 ` Peter Zijlstra
2019-10-14 17:49 ` Manfred Spraul
2019-10-14 19:03 ` Davidlohr Bueso
2019-10-15 7:45 ` Peter Zijlstra
2019-10-15 20:31 ` Waiman Long
2019-10-15 1:26 ` Davidlohr Bueso
2019-10-15 7:19 ` Peter Zijlstra
2019-10-15 16:26 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014123728.GE2328@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=1vier1@web.de \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox