Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

Michal Kubecek
2019-10-14T08:48:18Z

On Sat, Oct 12, 2019 at 06:33:09PM +0200, Jiri Pirko wrote:
> Wed, Oct 09, 2019 at 10:59:43PM CEST, mkubecek@suse.cz wrote:
>
> [...]
>
> >+static const struct nla_policy linkinfo_hdr_policy[ETHTOOL_A_HEADER_MAX + 1] = {
> >+ [ETHTOOL_A_HEADER_UNSPEC] = { .type = NLA_REJECT },
> >+ [ETHTOOL_A_HEADER_DEV_INDEX] = { .type = NLA_U32 },
> >+ [ETHTOOL_A_HEADER_DEV_NAME] = { .type = NLA_NUL_STRING,
> >+ .len = IFNAMSIZ - 1 },
>
> Please make ETHTOOL_A_HEADER_DEV_NAME accept alternative names as well.
> Just s/IFNAMSIZ/ALTIFNAMSIZ should be enough.

Yes, definitely. I focused on (finally) submitting v7 so I didn't left
testing how it plays with altnames for later.

Michal

> >+ [ETHTOOL_A_HEADER_GFLAGS] = { .type = NLA_U32 },
> >+ [ETHTOOL_A_HEADER_RFLAGS] = { .type = NLA_REJECT },
> >+};
>
> …