From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 986D9ECE587 for ; Mon, 14 Oct 2019 15:12:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67A0C2133F for ; Mon, 14 Oct 2019 15:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571065933; bh=KF9lPPdouuK9SQsaYgp33MOp4tIf20dFk8q5UKD3JIU=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=f2Vof/P8gJb9YXoCQJyIi9QsTe+y6pcO7k0KrjxXP+uqaAlE3ex5uk4y8mUMq6ieD MeWV+va1jznUIG26ni6gRdmzNrbWqaPmWYoPW7epIHaD56tc96kVucDnnXVsmJ5PQW LTkJhm9MGrOnH/aUHIskVgH2a67qZNWGGeRPLwJY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733275AbfJNPMM (ORCPT ); Mon, 14 Oct 2019 11:12:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:52278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732223AbfJNPMM (ORCPT ); Mon, 14 Oct 2019 11:12:12 -0400 Received: from localhost (odyssey.drury.edu [64.22.249.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C3752133F; Mon, 14 Oct 2019 15:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571065931; bh=KF9lPPdouuK9SQsaYgp33MOp4tIf20dFk8q5UKD3JIU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dSvV12fiK+ueZOx9yN/TgVW9nmoHgErNUPSe2pAL8Ma8jLjRiTm9EKG5e47N5ZTOW mQVoAjWacOe8ABUdxWKw5fmOogLVOVBrvA/fTcMeyzfVYdLDeifhe8H9twzjTn5aTa tOfZXzuSsHLnu5xbaiMdLw5expWU4nyiZwAzB330= Date: Mon, 14 Oct 2019 10:12:09 -0500 From: Bjorn Helgaas To: Greg Kroah-Hartman Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: msi: remove pci_irq_get_node() as no one is using it Message-ID: <20191014151209.GA183158@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014100452.GA6699@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 14, 2019 at 12:04:52PM +0200, Greg Kroah-Hartman wrote: > The function pci_irq_get_node() is not used by anyone in the tree, so > just delete it. > > Cc: Bjorn Helgaas > Signed-off-by: Greg Kroah-Hartman Applied with Andrew's Reviewed-by to psi/msi for v5.5, thanks! > --- > > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c > index 0884bedcfc7a..f95fe23830f0 100644 > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -1315,22 +1315,6 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr) > } > EXPORT_SYMBOL(pci_irq_get_affinity); > > -/** > - * pci_irq_get_node - return the NUMA node of a particular MSI vector > - * @pdev: PCI device to operate on > - * @vec: device-relative interrupt vector index (0-based). > - */ > -int pci_irq_get_node(struct pci_dev *pdev, int vec) > -{ > - const struct cpumask *mask; > - > - mask = pci_irq_get_affinity(pdev, vec); > - if (mask) > - return local_memory_node(cpu_to_node(cpumask_first(mask))); > - return dev_to_node(&pdev->dev); > -} > -EXPORT_SYMBOL(pci_irq_get_node); > - > struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc) > { > return to_pci_dev(desc->dev); > diff --git a/include/linux/pci.h b/include/linux/pci.h > index f9088c89a534..755d8c0176b9 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1454,7 +1454,6 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs, > void pci_free_irq_vectors(struct pci_dev *dev); > int pci_irq_vector(struct pci_dev *dev, unsigned int nr); > const struct cpumask *pci_irq_get_affinity(struct pci_dev *pdev, int vec); > -int pci_irq_get_node(struct pci_dev *pdev, int vec); > > #else > static inline int pci_msi_vec_count(struct pci_dev *dev) { return -ENOSYS; } > @@ -1497,11 +1496,6 @@ static inline const struct cpumask *pci_irq_get_affinity(struct pci_dev *pdev, > { > return cpu_possible_mask; > } > - > -static inline int pci_irq_get_node(struct pci_dev *pdev, int vec) > -{ > - return first_online_node; > -} > #endif > > /**