From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09554C10F14 for ; Tue, 15 Oct 2019 10:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D408A2089C for ; Tue, 15 Oct 2019 10:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731276AbfJOKpu (ORCPT ); Tue, 15 Oct 2019 06:45:50 -0400 Received: from 8bytes.org ([81.169.241.247]:47402 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726653AbfJOKpu (ORCPT ); Tue, 15 Oct 2019 06:45:50 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 3E5212D9; Tue, 15 Oct 2019 12:45:48 +0200 (CEST) Date: Tue, 15 Oct 2019 12:45:46 +0200 From: Joerg Roedel To: Heiko Stuebner Cc: iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: don't use platform_get_irq to implicitly count irqs Message-ID: <20191015104546.GD14518@8bytes.org> References: <20190925184346.14121-1-heiko@sntech.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925184346.14121-1-heiko@sntech.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 08:43:46PM +0200, Heiko Stuebner wrote: > Till now the Rockchip iommu driver walked through the irq list via > platform_get_irq() until it encountered an ENXIO error. With the > recent change to add a central error message, this always results > in such an error for each iommu on probe and shutdown. > > To not confuse people, switch to platform_count_irqs() to get the > actual number of interrupts before walking through them. > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Heiko Stuebner > --- > drivers/iommu/rockchip-iommu.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) Applied for v5.4, thanks.