Re: [PATCH v1 11/17] ARM: dts: tegra20: Add CPU Operating Performance Points

Dmitry Osipenko
2019-10-16T13:21:25Z

16.10.2019 08:23, Viresh Kumar пишет:
> On 16-10-19, 00:16, Dmitry Osipenko wrote:
>> Operating Point are specified per HW version. The OPP voltages are kept
>> in a separate DTSI file because some boards may not define CPU regulator
>> in their device-tree if voltage scaling isn't necessary, like for example
>> in a case of tegra20-trimslice which is outlet-powered device.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> .../boot/dts/tegra20-cpu-opp-microvolt.dtsi | 201 ++++++++++++
>> arch/arm/boot/dts/tegra20-cpu-opp.dtsi | 302 ++++++++++++++++++
>> 2 files changed, 503 insertions(+)
>> create mode 100644 arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi
>> create mode 100644 arch/arm/boot/dts/tegra20-cpu-opp.dtsi
>>
>> diff --git a/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi b/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi
>> new file mode 100644
>> index 000000000000..e85ffdbef876
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi
>> @@ -0,0 +1,201 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>> +/ {
>> + cpu0_opp_table: cpu_opp_table0 {
>> + opp@216000000_750 {
>
> Maybe just drop the _750 (i.e. voltage) from the names as we don't generally
> follow it :)

The reason for the _750 postfix is that there are multiple OPPs for
216MHz and they have different voltages for different versions of
hardware, thus those are separate OPPs and they can't be squashed into a
single OPP node.