From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19217ECE58F for ; Tue, 15 Oct 2019 22:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA9322064A for ; Tue, 15 Oct 2019 22:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571178591; bh=UB/4jJKABH22Sky8ezj5JPIBvG6gBSOCm6Ly33RNNGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EZM2fZNIAFWcWC4NssV/XBnPuU88YCnNoWniiP1++9UfhiHNOdLwNMSTLyebYIyfg NxgNOfh6sJJG17oK2Y7RyecD4SAP6nIT3RUangfcBi7rQOxAj4D75jflqLZ+c/WxDq XoYTmC4jzIUuWZnrcv5sx+lEZOgkv8+KepwFnsjM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389916AbfJOW3u (ORCPT ); Tue, 15 Oct 2019 18:29:50 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:44469 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389902AbfJOW3u (ORCPT ); Tue, 15 Oct 2019 18:29:50 -0400 Received: by mail-ot1-f68.google.com with SMTP id 21so18396560otj.11; Tue, 15 Oct 2019 15:29:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vrE5B9TKEy0Ahf3PltGkrbQZJCBK9Th8CtGSMcMqVcE=; b=ZI1rJc8R2QV8iJi9ysmoEWo4n+d+ejAXqWCeBMQ99V5kHMH3bIBoHZTibTbRFFm0oZ 5rpzxf+7xYfMDta56gaIblQ0KFMzch4NUqFO4tr96FGRnOLCAhPktrxdzAUOLrdjXahV m8rjBFHKo/4tX2LLdDJ+mMAkk1aIG5OvXICopudM2fiMktnfH5eNKcvCVmhC9WcyJpuC 9O6Are37YlhndpFYxiCc5OE6zBzQdw3RkSWlfan8vzLiwnfK5WlLdepVMrfL8fmW4nKY PBXNmS0QnM+fnzepS/gAol5HnYAJJtrKitGVLYW4Q6cwCHFzJtrOxRZdzT3Bfqrl1Zc8 yB8A== X-Gm-Message-State: APjAAAUNdifjQtEwNaZpNFnK2/nLS3UGLuyoTvSO+Bmw3mYz6rC6GhCW vIwHB5kbXCLlAEAlQ+SmvGpYjL4= X-Google-Smtp-Source: APXvYqwrJv+FLlYQeraNR8fsDqy1zId6Y5dKvTXqDqkfTJWxeP0UhxcGwuqnMSXi1bDmu4jRLcXUsg== X-Received: by 2002:a05:6830:22d9:: with SMTP id q25mr29736448otc.87.1571178589083; Tue, 15 Oct 2019 15:29:49 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l19sm6459488oie.22.2019.10.15.15.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 15:29:48 -0700 (PDT) Date: Tue, 15 Oct 2019 17:29:47 -0500 From: Rob Herring To: Benoit Parrot Cc: Tony Lindgren , Tero Kristo , linux-omap@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch 1/3] dt-bindings: media: ti-vpe: Document VPE driver Message-ID: <20191015222947.GA13388@bogus> References: <20191009175628.20570-1-bparrot@ti.com> <20191009175628.20570-2-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009175628.20570-2-bparrot@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 09, 2019 at 12:56:26PM -0500, Benoit Parrot wrote: > Device Tree bindings for the Video Processing Engine (VPE) driver. > > Signed-off-by: Benoit Parrot > --- > .../devicetree/bindings/media/ti-vpe.txt | 48 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt Please convert to DT schema format. > > diff --git a/Documentation/devicetree/bindings/media/ti-vpe.txt b/Documentation/devicetree/bindings/media/ti-vpe.txt > new file mode 100644 > index 000000000000..b2942fa8c3ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/ti-vpe.txt > @@ -0,0 +1,48 @@ > +Texas Instruments DRA7x VIDEO PROCESSING ENGINE (VPE) > +------------------------------------------------------ > + > +The Video Processing Engine (VPE) is a key component for image post > +processing applications. VPE consist of a single memory to memory > +path which can perform chroma up/down sampling, deinterlacing, > +scaling and color space conversion. > + > +Required properties: > +- compatible: must be "ti,vpe" Needs to have SoC specific compatibles. > +- reg: physical base address and length of the registers set for the 4 > + memory regions required; > +- reg-names: name associated with the memory regions described is ; The names need to be documented. > +- interrupts: should contain IRQ line for VPE; > + > +Example: > + > + target-module@1d0010 { /* 0x489d0000, ap 27 30.0 */ > + compatible = "ti,sysc-omap4", "ti,sysc"; > + reg = <0x1d0010 0x4>; > + reg-names = "sysc"; > + ti,sysc-midle = , > + , > + ; > + ti,sysc-sidle = , > + , > + ; > + clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>; > + clock-names = "fck"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x1d0000 0x10000>; All this is outside the scope of this binding. > + > + vpe: vpe@0 { > + compatible = "ti,vpe"; > + reg = <0x0000 0x120>, > + <0x0700 0x80>, > + <0x5700 0x18>, > + <0xd000 0x400>; > + reg-names = "vpe_top", > + "sc", > + "csc", > + "vpdma"; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; Not documented, nor needed as there are no child nodes. > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 8598f49fa2c8..63dcda51f8ae 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16299,6 +16299,7 @@ W: http://linuxtv.org/ > Q: http://patchwork.linuxtv.org/project/linux-media/list/ > S: Maintained > F: drivers/media/platform/ti-vpe/ > +F: Documentation/devicetree/bindings/media/ti-vpe.txt > > TI WILINK WIRELESS DRIVERS > L: linux-wireless@vger.kernel.org > -- > 2.17.1 >