From: Luis Chamberlain <mcgrof@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tuowen Zhao <ztuowen@gmail.com>,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
AceLan Kao <acelan.kao@canonical.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc
Date: Wed, 16 Oct 2019 12:56:15 +0000 [thread overview]
Message-ID: <20191016125615.GI16384@42.do-not-panic.com> (raw)
In-Reply-To: <20191015074434.GU32742@smile.fi.intel.com>
On Tue, Oct 15, 2019 at 10:44:34AM +0300, Andy Shevchenko wrote:
> On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> > On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > > -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # save the attached .config to linux build tree
> > > GCC_VERSION=7.4.0 make.cross ARCH=sparc64
> >
> > Oops, I'm not sure how would we best fix this. Clearly the patch is not
> > intended for sparc64. Maybe adding devm_ioremap_uc is rather not safe
> > right now.
>
> It seems you need a preparatory patch to satisfy sparc64.
Indeed, can you add that? If you are not comfortable the way to leave
behind lazy architectures is the HAS_FOO feature and then have your
driver require that or depend on the archs that support this. This
allows non-lazy architecturess to move forward with life.
Luis
next prev parent reply other threads:[~2019-10-16 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 15:33 [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc Tuowen Zhao
2019-10-14 15:33 ` [PATCH v4 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-14 18:46 ` [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc kbuild test robot
2019-10-14 19:15 ` Tuowen Zhao
2019-10-15 7:44 ` Andy Shevchenko
2019-10-16 12:56 ` Luis Chamberlain [this message]
2019-10-16 17:58 ` Tuowen Zhao
2019-12-04 11:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016125615.GI16384@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ztuowen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox