From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2F5FA3728 for ; Wed, 16 Oct 2019 14:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7BFF21925 for ; Wed, 16 Oct 2019 14:40:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t2WIQRuE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405737AbfJPOkY (ORCPT ); Wed, 16 Oct 2019 10:40:24 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38954 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405214AbfJPOkX (ORCPT ); Wed, 16 Oct 2019 10:40:23 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 34F3C9F4; Wed, 16 Oct 2019 16:40:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571236821; bh=Ix3XoJ8c2YHEbbRw/h23s9VQOlN2/0+X/ZG7Iozx4OM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t2WIQRuEIMiyqAfhI9K8seGMZLbuogVv7sRdQ7WqmidxqES1u0zjmgqsIAcvtNU0X 7hOxXRHo7DR3i+oByIuV5RL8j6//k0NHBiGcO2C9kzqa9jMY4EOZznm/CB7A/E20Et OKbsxfLMRm3Payf72G5DnLmaBjHgn8ddDYDVKxHs= Date: Wed, 16 Oct 2019 17:40:18 +0300 From: Laurent Pinchart To: Adam Ford Cc: dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Sebastian Reichel , Tomi Valkeinen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel Message-ID: <20191016144018.GG5175@pendragon.ideasonboard.com> References: <20191016135147.7743-1-aford173@gmail.com> <20191016135147.7743-2-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191016135147.7743-2-aford173@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adam, Thank you for the patch. On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote: > This patch adds documentation of device tree bindings for the WVGA panel > Logic PD Type 28 display. > > Signed-off-by: Adam Ford > --- > V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k > V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 > V3: Correct build errors from 'make dt_binding_check' > V2: Use YAML instead of TXT for binding > > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > new file mode 100644 > index 000000000000..2834287b8d88 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel > + > +maintainers: > + - Adam Ford > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: logicpd,type28 > + > + power-supply: true > + enable-gpios: true > + backlight: true > + port: true > + > +required: > + - compatible Should the port be required too ? Apart from that, Reviewed-by: Laurent Pinchart > + > +additionalProperties: false > + > +examples: > + - | > + lcd0: display { > + compatible = "logicpd,type28"; > + enable-gpios = <&gpio5 27 0>; > + backlight = <&backlight>; > + port { > + lcd_in: endpoint { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + }; > + > +... -- Regards, Laurent Pinchart