Re: [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

Randy Dunlap
2019-10-14T05:41:12Z

Hi,

On 10/13/19 10:31 PM, Corentin Labbe wrote:
> diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig
> new file mode 100644
> index 000000000000..9c4bf96afeb3
> --- /dev/null
> +++ b/drivers/crypto/amlogic/Kconfig
> @@ -0,0 +1,24 @@
> +config CRYPTO_DEV_AMLOGIC_GXL
> + tristate "Support for amlogic cryptographic offloader"
> + default y if ARCH_MESON
> + select CRYPTO_BLKCIPHER
> + select CRYPTO_ENGINE
> + select CRYPTO_ECB
> + select CRYPTO_CBC
> + select CRYPTO_AES
> + help
> + Select y here for having support for the cryptographic offloader

to have support for

> + availlable on Amlogic GXL SoC.

available

> + This hardware handle AES ciphers in ECB/CBC mode.

handles

> +
> + To compile this driver as a module, choose M here: the module
> + will be called amlogic-crypto.

That module name does not match the Makefile's name.

> +
> +config CRYPTO_DEV_AMLOGIC_GXL_DEBUG
> + bool "Enabled amlogic stats"

Enable

> + depends on CRYPTO_DEV_AMLOGIC_GXL
> + depends on DEBUG_FS
> + help
> + Say y to enabled amlogic-crypto debug stats.

enable

> + This will create /sys/kernel/debug/gxl-crypto/stats for displaying
> + the number of requests per flow and per algorithm.
> diff --git a/drivers/crypto/amlogic/Makefile b/drivers/crypto/amlogic/Makefile
> new file mode 100644
> index 000000000000..39057e62c13e
> --- /dev/null
> +++ b/drivers/crypto/amlogic/Makefile
> @@ -0,0 +1,2 @@
> +obj-$(CONFIG_CRYPTO_DEV_AMLOGIC_GXL) += amlogic-gxl-crypto.o
> +amlogic-gxl-crypto-y := amlogic-gxl-core.o amlogic-gxl-cipher.o

--
~Randy