Re: [PATCH v2 5/5] ARM: mstar: Add dts for 70mai midrive d08

Andreas Färber
2020-06-11T13:54:47Z

BTW I think the subject convention has been "ARM: dts: ...", with "ARM:
mstar: ..." more for mach-mstar.

Am 10.06.20 um 11:04 schrieb Daniel Palmer:
> Adds inital support for the 70mai midrive d08 dash camera.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> arch/arm/boot/dts/Makefile | 3 ++-
> .../boot/dts/mercury5-ssc8336n-midrive08.dts | 25 +++++++++++++++++++
> 2 files changed, 27 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 4a5f8075a4f6..35c7ecc52c60 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1344,7 +1344,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
> dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb
> dtb-$(CONFIG_ARCH_MSTARV7) += \
> infinity-msc313-breadbee_crust.dtb \
> - infinity3-msc313e-breadbee.dtb
> + infinity3-msc313e-breadbee.dtb \
> + mercury5-ssc8336n-midrive08.dtb
> dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb
> dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-ast2500-evb.dtb \
> diff --git a/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts b/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
> new file mode 100644
> index 000000000000..4ee50ecf6ab1
> --- /dev/null
> +++ b/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + */
> +
> +/dts-v1/;
> +#include "mercury5-ssc8336n.dtsi"
> +
> +/ {
> + model = "midrive d08";

Couldn't find this on their website. Should this be "70mai midrive ..."
or is "midrive" a different brand?

> + compatible = "70mai,midrived08", "mstar,mercury5";

Have you considered naming it "70mai,midrive-d08" for better
readability? (affects 1/5)

> +
> + aliases {
> + serial0 = &pm_uart;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&pm_uart {
> + status = "okay";

clock-frequency?

> +};

Regards,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)