From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B62EECE599 for ; Wed, 16 Oct 2019 22:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0621F207FF for ; Wed, 16 Oct 2019 22:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571264236; bh=9CZK8fiOuOEEttmvAJF3qxboAumotw1zuT9VWq4eyVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=t5rFkHycSPTwGesAE2iJnABC+27WXezsJLJ365PxHjxadh449WmRiXcEGDLieIaN9 14bxpDveqB8jw65TJBFNFarzx6cAp4Tox1rtkRY9gDOH3Myoxzww5UhLPMHvpQQ041 n9mKQ+QelqaB9qv/jhmjAYuZNuYoIlSP9Mz362R0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731060AbfJPWRP (ORCPT ); Wed, 16 Oct 2019 18:17:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:45150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395107AbfJPVy4 (ORCPT ); Wed, 16 Oct 2019 17:54:56 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6506C218DE; Wed, 16 Oct 2019 21:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571262896; bh=9CZK8fiOuOEEttmvAJF3qxboAumotw1zuT9VWq4eyVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lruisrMN5YFOBippyRKhsifA7Zrr2OlOzwZF+R9jQTwRrksEP6sFAe6K4AUb6DEbk hmFQ5SVBs1lvHl6J59Wc542cP3Udaw6tFPfIzMECaOUv/TR84f/xM5Mat3bkGxIJqf pm9fnHvvFCGmbBW4Wpv+jJrI+R7vMqJjvZEylpgA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Aring , syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com, Johan Hovold , Stefan Schmidt Subject: [PATCH 4.9 13/92] ieee802154: atusb: fix use-after-free at disconnect Date: Wed, 16 Oct 2019 14:49:46 -0700 Message-Id: <20191016214809.607606326@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214759.600329427@linuxfoundation.org> References: <20191016214759.600329427@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 7fd25e6fc035f4b04b75bca6d7e8daa069603a76 upstream. The disconnect callback was accessing the hardware-descriptor private data after having having freed it. Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver") Cc: stable # 4.2 Cc: Alexander Aring Reported-by: syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/atusb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -838,10 +838,11 @@ static void atusb_disconnect(struct usb_ ieee802154_unregister_hw(atusb->hw); + usb_put_dev(atusb->usb_dev); + ieee802154_free_hw(atusb->hw); usb_set_intfdata(interface, NULL); - usb_put_dev(atusb->usb_dev); pr_debug("atusb_disconnect done\n"); }